astraea-974 Implement RecordHandler post request #1156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chia7712
reviewed
Nov 21, 2022
|
@chia7712 PTAL! |
chia7712
reviewed
Nov 22, 2022
| public interface Request { | ||
|
|
||
| /** Indicates the object used in the request */ | ||
| interface RequestObject {} |
There was a problem hiding this comment.
主要想解決 之前提過的一個問題
在Request 中的field 是 generic 的 Object 的話 會拿不到他的Class
所以沒辦法做一些testing 上的驗證
像是以下
static class RecordPostRequest implements Request {
List<PostRecord> records = List.of();
}
這裡直接在那些PostRecord上面加上這個interface 來做驗證
There was a problem hiding this comment.
不好意思，我最近記憶力有點薄弱，我講錯的話就請提醒我一下
現在的驗證是驗證一個「建構出來的物件」，因此 records 這個變數我們就是驗證它是否為 null 以及 它內涵的物件（而非generic type）是否有符合規範。
條列的地來說，一個 Request / Response 物件只能有三種 members
- primitive type
- Map optional collection
- 其他 Request
因此在我的想像中，PostRecord 應該也是繼承 Request 就好
There was a problem hiding this comment.
瞭解
PostRecord 也是可以繼承 Request 的
只是原本定義的 Request 是user 會傳上來的 json 物件
所以才用別的interface 來代表是Request 中會使用到的其他物件
chia7712
reviewed
Nov 22, 2022
| var keySerializer = SerDe.ofAlias(postRecord.keySerializer).serializer; | ||
| var valueSerializer = SerDe.ofAlias(postRecord.valueSerializer).serializer; | ||
| postRecord.key.ifPresent( | ||
| key -> builder.key(keySerializer.apply(topic, PostRequest.handle(key)))); |
There was a problem hiding this comment.
這邊簡單一點，就直接呼叫toString取代PostRequest.handle，然後留個TODO，描述說要處理只能傳入 number and string，並且開好對應的議題
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #974 Implement RecordHandler