Skip to content

Commit

Permalink
Merge pull request #277 from bgilbert/binutils
Browse files Browse the repository at this point in the history
Fix Windows exported symbol check on binutils 2.43; bump builder API version
  • Loading branch information
bgilbert authored Sep 2, 2024
2 parents 18dc4f3 + a321616 commit 39815d2
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
4 changes: 3 additions & 1 deletion artifacts/postprocess-binary.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,9 @@ def library_symbols(file: Path) -> list[str]:
if active:
if not line.strip():
return syms
syms.append(line.split()[2])
sym = line.split()[-1]
if sym != 'Name':
syms.append(sym)
elif 'Ordinal/Name Pointer' in line:
active = True
raise Exception("Couldn't parse objdump output")
Expand Down
2 changes: 1 addition & 1 deletion bintool
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ from common.meson import (
)
from common.software import Project

WINDOWS_API_VERS = (4,)
WINDOWS_API_VERS = (4, 5)
LINUX_API_VERS = (3,)
# we have a higher minimum than the underlying meson.build
MESON_MIN_VER = (1, 5, 0)
Expand Down
2 changes: 1 addition & 1 deletion builder/windows/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ FROM docker.io/gentoo/stage3:latest
# NOTE: try to keep the current container image compatible with the latest
# stable source release, so people can conveniently build from the source
# tarball
RUN touch /etc/openslide-winbuild-builder-v{3,4}
RUN touch /etc/openslide-winbuild-builder-v5
RUN echo 'FEATURES="-sandbox -usersandbox -ipc-sandbox -network-sandbox -pid-sandbox"' >> /etc/portage/make.conf
COPY package.accept_keywords /etc/portage/package.accept_keywords/openslide
COPY package.use /etc/portage/package.use/openslide
Expand Down

0 comments on commit 39815d2

Please sign in to comment.