Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix agent inheritance test to wait for running #296

Merged
merged 1 commit into from
Apr 9, 2018
Merged

Fix agent inheritance test to wait for running #296

merged 1 commit into from
Apr 9, 2018

Conversation

Peque
Copy link
Member

@Peque Peque commented Apr 9, 2018

@Peque Peque added this to the 0.7.0 milestone Apr 9, 2018
@Peque Peque self-assigned this Apr 9, 2018
@Peque Peque requested a review from ocaballeror April 9, 2018 09:17
ocaballeror
ocaballeror approved these changes Apr 9, 2018
View reviewed changes
Copy link
Contributor

@ocaballeror ocaballeror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough 👍

I'm still surprised this only started failing now, though

@Peque Peque merged commit cffe79b into opensistemas-hub:master Apr 9, 2018
@ocaballeror ocaballeror mentioned this pull request Apr 9, 2018
Merged
@Peque
Copy link
Member Author

Peque commented Apr 9, 2018

Yeah, rather than started I think it just happened (i.e.: if we run our test suite another 100 times, maybe it would not appear again). 😅

@codecov
Copy link

codecov bot commented Apr 9, 2018 •
edited
Loading

Codecov Report

Merging #296 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #296      +/-   ##
=========================================
+ Coverage    99.1%   99.1%   +<.01%     
=========================================
  Files          26      26              
  Lines        3556    3557       +1     
  Branches      258     258              
=========================================
+ Hits         3524    3525       +1     
  Misses         19      19              
  Partials       13      13
Impacted Files Coverage Δ
osbrain/tests/test_agent.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 969c7a1...cffe79b. Read the comment docs.

@Peque Peque deleted the fixbug branch April 9, 2018 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocaballeror ocaballeror ocaballeror approved these changes

Assignees

@Peque Peque

Labels
bug test
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Peque @ocaballeror