Ignore warnings related to deprecated stdext::checked_array_iterator on MSVC

[nickbianco]

Fixes issue with the Windows 2022 GitHub Actions runner failing because MSVC deprecated stdext::checked_array_iterator, which was used by an older version of fmtlib (dependency of spdlog).

Brief summary of changes

Updated spdlog to v1.14.1.

Update: rather than try to update spdlog, I've changed this PR to ignore the warning on MSVC (per @adamkewley's suggestion).

Testing I've completed

Running the CI suite.

Looking for feedback on...

Should the added target_compile_options be moved outside of the macro (i.e., used only for libraries compiled with spdlog)?

CHANGELOG.md (choose one)

• no need to update because...CI fix.

---

This change is 

[adamkewley]

It's going to be rough to actually rollout the latest spdlog, because it requires going through every printable type (incl. those from simbody) and annotating the relevant datastructures to say "ostream this".

OpenSim Creator's been getting this warning for a couple of years now, because it's compiling with /W4, the way to ignore it is by disabling the warning:

• https://github.com/ComputationalBiomechanicsLab/opensim-creator/blob/main/src/OpenSimCreator/CMakeLists.txt#L450

Not exactly a great solution but if you want CI back up-and-running then I'd maybe consider first disabling those warnings and then separately try to sort out the spdlog upgrade, so that you aren't getting pressure from PRs etc. to fix CI

[nickbianco]

Thanks @adamkewley, I think patching the issue by disabling warnings is better for now. I'll switch this PR to do that instead.

[adamkewley]

Seems to do the trick! - sucks to ignore warnings but it gets the project's wheels turning while evaluating what to do (imo, I'd de-integrate spdlog+fmt around the time OpenSim upgrades to C++20 on target platforms that include std::format - drops a dependency but means you can still use the "{}" syntax