Removal of const in signal set, add and minor changes #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@naveen-rn Please review to determine if these changes can be handled by the signals section committee. |
naveen-rn
approved these changes
Aug 27, 2024
wrrobin
force-pushed
the
pr/rm_const_signal
branch
from
c8341ef to
1a7bf49
Compare
naveen-rn
approved these changes
Aug 29, 2024
| @@ -11,7 +11,7 @@ | |||
|
|
|||
| \begin{apiarguments} | |||
|
|
|||
| \apiargument{IN}{sig\_addr}{Local address of the source signal variable.} | |||
| \apiargument{IN}{sig\_addr}{Local address of the remotely accessible source signal variable.} | |||
There was a problem hiding this comment.
This was there in the original PR commit here, if that is what you are asking. I thought this can be treated as a doc edit.
|
Closing this as the changes are merged in https://github.com/naveen-rn/specification/tree/osm1.6/rc1-rma-amo-pws and will be opened as PR once ready as section edits. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This PR address issue #509. Also, restructures signaling section.
Adds a minor change to the
sig_addrdescription ofshmem_signal_wait_until.Proposal Checklist