Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RMA, AMO, Reduction edits #362

Merged
merged 1 commit into from
Apr 27, 2020
Merged

RMA, AMO, Reduction edits #362

merged 1 commit into from
Apr 27, 2020

Conversation

shamisp
Copy link
Contributor

@shamisp shamisp commented Feb 6, 2020

  • Adding macro for subsubsubsection
  • Moving blocking and non_blocking RMA into one subsubsection
  • Moving blocking and non_blocking AMO into one subsubsection
  • Updating AMO introduction to reflect support for non_blocking
    operations
  • Reduction paragraph was replaced with subsubsubsection to make the
    text consistent

Signed-off-by: Pavel Shamis (Pasha) [email protected]

@shamisp
RMA, AMO, Reduction edits
4690309 
* Adding macro for subsubsubsection
* Moving blocking and non_blocking RMA into one subsubsection
* Moving blocking and non_blocking AMO into one subsubsection
* Updating AMO introduction to reflect support for non_blocking
operations
* Reduction paragraph was replaced with subsubsubsection to make the
text consistent

Signed-off-by: Pavel Shamis (Pasha) <[email protected]>
@shamisp shamisp added this to the OpenSHMEM 1.5 milestone Feb 6, 2020
@shamisp
Copy link
Contributor Author

shamisp commented Feb 6, 2020

Fixing #216

@shamisp shamisp mentioned this pull request Feb 6, 2020
Closed
@shamisp
Copy link
Contributor Author

shamisp commented Feb 6, 2020

@nspark this PR touched collectives. Reduction used paragraphs and I made it consistent across chapters. Please let me know if this is okay. Otherwise I can open separate PR just with the reduction change.

@shamisp
Copy link
Contributor Author

shamisp commented Feb 6, 2020

@manjugv can you please review as well. thanks

@manjugv manjugv self-requested a review February 7, 2020 20:13
@jdinan
Copy link
Collaborator

jdinan commented Feb 10, 2020

Please move this PR to the relevant section committee branch.

@shamisp
Copy link
Contributor Author

shamisp commented Feb 14, 2020

@jdinan How do I do it and what is the relevant branch ? thanks !

@jdinan
Copy link
Collaborator

jdinan commented Feb 14, 2020

You're the chair, so please create a branch on the current openshmem-org:master head for RMA/AMO/Signal section edits on your fork: shamisp:sec/rma-amo. Post the changes on this PR as a PR against that section committee branch, request reviews from your committee members, and merge into section edits once section committee approves. Thanks!

@shamisp
Copy link
Contributor Author

shamisp commented Feb 14, 2020

@jdinan - got it. thanks.

@shamisp
Copy link
Contributor Author

shamisp commented Feb 14, 2020

As @jdinan requested moved the PR here shamisp#1

I guess I have to ask @jdinan @nspark @manjugv re-approve the new PR. I will close this one and just reference the discussion from the new PR.

@shamisp shamisp mentioned this pull request Feb 14, 2020
Merged
@jdinan
Copy link
Collaborator

jdinan commented Mar 2, 2020

@shamisp IIUC, this PR was superseded by shamisp#1. Can it be closed?

@jdinan jdinan merged commit 6085b6c into openshmem-org:master Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manjugv manjugv manjugv approved these changes

Assignees
No one assigned
Labels
SectionCommittee
Projects
No open projects
OpenSHMEM 1.5rc1 Section Committees
Status: RMA, AMO, and Signals (9.6-9.10)
Milestone
OpenSHMEM 1.5
Development

Successfully merging this pull request may close these issues.
3 participants
@shamisp @jdinan @manjugv