Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update formatting on Profiling examples #343

Closed
wants to merge 1 commit into from

Conversation

nspark
Copy link
Contributor

@nspark nspark commented Feb 5, 2020

This PR builds on #237—the only commit unique to this PR is d2e61b8—but is significant enough to not be strictly editorial. It updates the example listings to use the new macros, but slightly adjusts the caption text to suit the new structure.

Thus, commit d2e61b8 will need approval by the Profiling Interfaces Section Committee (@jlinford, @agrippa, @wrrobin, @swpoole). (Viewing the diff while hiding whitespace changes is most clear, as there were trailing spaces that were removed.)

@nspark nspark added this to the OpenSHMEM 1.5 milestone Feb 5, 2020
@nspark nspark requested review from wrrobin, agrippa and swpoole February 5, 2020 04:17
@wrrobin
Copy link
Collaborator

wrrobin commented Feb 5, 2020

Thanks @nspark. The changes look good. Can we also update the pshmem_example as James suggested on #237? Not sure whether this can be a doc edit though.

@nspark
Copy link
Contributor Author

nspark commented Feb 5, 2020

Thanks @nspark. The changes look good. Can we also update the pshmem_example as James suggested on #237? Not sure whether this can be a doc edit though.

I think we should leave that change to the Section Committee to change in the coming weeks. I'd like to get the rest of the example changes in today, ideally.

@agrippa
Copy link
Collaborator

agrippa commented Feb 5, 2020

LGTM

@jdinan
Copy link
Collaborator

jdinan commented Feb 10, 2020

@nspark Could you please rebase or merge with master so the diff is easier to review? Given the stage we are at now, my preference would be to avoid any more changes directly on master and instead merge this into the section committee's branch.

@nspark nspark force-pushed the improve-examples-prof branch from d2e61b8 to a2d6fe5 Compare February 26, 2020 21:14
@nspark
Copy link
Contributor Author

nspark commented Feb 26, 2020

@jdinan Rebased as requested!

Copy link
Collaborator

@jdinan jdinan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be merged into the profiling interfaces section instead of openshmem-org:master?

@nspark
Copy link
Contributor Author

nspark commented Feb 27, 2020

That should be fine, but it's up to @jlinford, @agrippa, and @wrrobin

@wrrobin
Copy link
Collaborator

wrrobin commented Feb 27, 2020

This is fine with me although, I am not aware of any section branch for profiling interfaces.

@jdinan
Copy link
Collaborator

jdinan commented Feb 27, 2020

@jlinford Is the profiling interfaces section chair.

@wrrobin
Copy link
Collaborator

wrrobin commented Feb 29, 2020

@nspark Can you please create the PR against wrrobin:sec/profiling-interface?

@nspark
Copy link
Contributor Author

nspark commented Mar 11, 2020

Replaced by wrrobin#3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Profiling Interfaces (Sec. 10)
Development

Successfully merging this pull request may close these issues.

4 participants