-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update formatting on Profiling examples #343
Conversation
I think we should leave that change to the Section Committee to change in the coming weeks. I'd like to get the rest of the example changes in today, ideally. |
LGTM |
@nspark Could you please rebase or merge with master so the diff is easier to review? Given the stage we are at now, my preference would be to avoid any more changes directly on master and instead merge this into the section committee's branch. |
d2e61b8
to
a2d6fe5
Compare
@jdinan Rebased as requested! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be merged into the profiling interfaces section instead of openshmem-org:master?
This is fine with me although, I am not aware of any section branch for profiling interfaces. |
@jlinford Is the profiling interfaces section chair. |
@nspark Can you please create the PR against wrrobin:sec/profiling-interface? |
Replaced by wrrobin#3 |
This PR builds on #237—the only commit unique to this PR is d2e61b8—but is significant enough to not be strictly editorial. It updates the example listings to use the new macros, but slightly adjusts the caption text to suit the new structure.
Thus, commit d2e61b8 will need approval by the Profiling Interfaces Section Committee (@jlinford, @agrippa, @wrrobin, @swpoole). (Viewing the diff while hiding whitespace changes is most clear, as there were trailing spaces that were removed.)