Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update atomic memory model text #204

Merged
merged 8 commits into from
Aug 23, 2018
Merged

Update atomic memory model text #204

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
902ee61
Update atomic memory model text
Feb 6, 2018
6ad7676
Update atomic mem model text and add anti-examples
Apr 26, 2018
617b2d4
Add 'undefined behavior' comments to AMO examples
May 29, 2018
18c8ea8
Merge branch 'master' into pr/atomicity-clarification
May 31, 2018
252a6a1
Add changelog entry
May 31, 2018
04a876d
Atomic memory model updates from May 21 reading
Jun 4, 2018
12e0687
Avoid specifying behavior for concurrent atomic compatible ops only
Jul 26, 2018
b3b5cfb
Remove concurrency and atomic compatiblity
Aug 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions content/memory_model.tex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,15 @@

\subsection{Atomicity Guarantees}\label{subsec:amo_guarantees}

\openshmem contains a number of routines that operate on symmetric data
atomically (Section \ref{sec:amo}). These routines guarantee that accesses by
\openshmem's atomic operations with the same datatype will be exclusive, but do not guarantee
exclusivity in combination with other routines, either inside \openshmem or
outside.
\openshmem contains a number of routines that perform atomic operations on
symmetric data objects (Section \ref{sec:amo}). These routines guarantee that
concurrent accesses to the same location by \openshmem atomic operations using
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add: "and atomic-compatible operations"?

the same datatype will be exclusive. However, they do not guarantee
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of "datatype" reference the table in the AMO section and use consistent terminology.

exclusivity when concurrent accesses to the same location are performed using
\openshmem atomic operations using different datatypes, when non-atomic
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add wait/test with same datatype

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jdinan, you mean to add wait/test with same datatype to the allowed/defined list, correct?

\openshmem operations are used to access the given location, or when
non-\openshmem operations are performed on the given location. The result in
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add: "(e.g. load and store operations)"

such scenarios is undefined.

For example: during the execution of an atomic remote integer increment
operation on a symmetric variable \VAR{X}, no other \openshmem atomic operation
Expand Down