Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed-width integer bindings for reductions #311

Closed
jdinan opened this issue Nov 8, 2019 · 2 comments
Closed

Fixed-width integer bindings for reductions #311

jdinan opened this issue Nov 8, 2019 · 2 comments
Assignees
Milestone

Comments

@jdinan
Copy link
Collaborator

jdinan commented Nov 8, 2019

Teams reduction operations don't have bindings for fixed-width integer types (e.g. int32_t). Do users need support for these types?

@nspark
Copy link
Contributor

nspark commented Feb 5, 2020

Here's the path we're taking...

  • Split the reduction types table between team- and active-set-based reductions
  • Add type support for fixed-width integer types (including size_t and ptrdiff_t) to team-based reductions
  • Set the type support for active-set-based reductions as matching the API of OpenSHMEM 1.4; i.e., 1.5 will not add any new active-set reduction types.

Here's the main point of feedback we're seeking:

  • Do we add support (or not) for bitwise operations in team-based reductions for C's standard signed integer types (i.e., char, signed char, short, int, long, long long)? These types are not required to be twos-complement and bitwise operations may not be supported on them on all architectures.

nspark added a commit to nspark/specification that referenced this issue Feb 6, 2020
- Specifies separate type tables for active-set- and team-based reductions
- Removes bitwise reduction support for signed integers over teams
- Adds fixed-width integer types for team-based reductions

Closes openshmem-org#311
@nspark
Copy link
Contributor

nspark commented Mar 10, 2020

Closed by 1.5rc1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Collectives (9.11)
Development

No branches or pull requests

2 participants