Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STOR-1593: Disable toplogy feature explicitly #241

Merged

Conversation

gnufied
Copy link
Member

@gnufied gnufied commented Jul 24, 2024

@openshift-ci openshift-ci bot requested review from bertinatto and RomanBednar July 24, 2024 14:19
Copy link
Contributor

openshift-ci bot commented Jul 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2024
@jsafrane
Copy link
Contributor

/lgtm

@gnufied
Copy link
Member Author

gnufied commented Jul 24, 2024

/payload-job periodic-ci-openshift-release-master-nightly-4.17-e2e-vsphere-ovn-csi

Copy link
Contributor

openshift-ci bot commented Jul 24, 2024

@gnufied: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.17-e2e-vsphere-ovn-csi

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5ef27d30-49d0-11ef-923b-180448ead2bb-0

@gnufied gnufied changed the title Disable toplogy feature explicitly OCPBUGS-37455: Disable toplogy feature explicitly Jul 24, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Jul 24, 2024
@openshift-ci-robot
Copy link
Contributor

@gnufied: This pull request references Jira Issue OCPBUGS-37455, which is invalid:

  • expected the bug to target the "4.17.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

fixes https://issues.redhat.com/browse/OCPBUGS-37455

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jul 24, 2024
@gnufied
Copy link
Member Author

gnufied commented Jul 24, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 24, 2024
@openshift-ci-robot
Copy link
Contributor

@gnufied: This pull request references Jira Issue OCPBUGS-37455, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @WenXinWei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from WenXinWei July 24, 2024 15:24
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 05fdfea and 2 for PR HEAD 060ffca in total

@bertinatto
Copy link
Member

/retest-required

1 similar comment
@bertinatto
Copy link
Member

/retest-required

@gnufied
Copy link
Member Author

gnufied commented Jul 24, 2024

While this fixes CSI volume provisioning issue. There are some other weirdness going on, which is causing specifically in-tree PVs to fail to delete with error:

2024-07-24T18:38:59.521133288Z vanilla/controller.go:2092 failed to get VolumeID from volumeMigrationService for volumePath: "[vsanDatastore-2] be583566-a662-6970-2903-3cfdfe8f21e0/_006c/_005a/c01a7c7317a24e0b934b5c233dfad560.vmdk"
sigs.k8s.io/vsphere-csi-driver/v3/pkg/csi/service/vanilla.(*controller).DeleteVolume.func1
        /go/src/github.com/kubernetes-sigs/vsphere-csi-driver/pkg/csi/service/vanilla/controller.go:2092
sigs.k8s.io/vsphere-csi-driver/v3/pkg/csi/service/vanilla.(*controller).DeleteVolume
        /go/src/github.com/kubernetes-sigs/vsphere-csi-driver/pkg/csi/service/vanilla/controller.go:2166
github.com/container-storage-interface/spec/lib/go/csi._Controller_DeleteVolume_Handler
        /go/src/github.com/kubernetes-sigs/vsphere-csi-driver/vendor/github.com/container-storage-interface/spec/lib/go/csi/csi.pb.go:6598
google.golang.org/grpc.(*Server).processUnaryRPC
        /go/src/github.com/kubernetes-sigs/vsphere-csi-driver/vendor/google.golang.org/grpc/server.go:1372
google.golang.org/grpc.(*Server).handleStream
        /go/src/github.com/kubernetes-sigs/vsphere-csi-driver/vendor/google.golang.org/grpc/server.go:1783
google.golang.org/grpc.(*Server).serveStreams.func2.1
        /go/src/github.com/kubernetes-sigs/vsphere-csi-driver/vendor/google.golang.org/grpc/server.go:1016
2024-07-24T18:3

@gnufied
Copy link
Member Author

gnufied commented Jul 24, 2024

/lgtm cancel

@jsafrane
Copy link
Contributor

/retitle Disable toplogy feature explicitly

I'm un-linking this PR from OCPBUGS-37455 - we fixed that bug by reverting external-provisioner rebase.

@openshift-ci openshift-ci bot changed the title OCPBUGS-37455: Disable toplogy feature explicitly Disable toplogy feature explicitly Jul 25, 2024
@openshift-ci-robot openshift-ci-robot removed jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Jul 25, 2024
@openshift-ci-robot
Copy link
Contributor

@gnufied: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

fixes https://issues.redhat.com/browse/OCPBUGS-37455

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jul 25, 2024
@gnufied gnufied closed this Jul 26, 2024
@jsafrane
Copy link
Contributor

jsafrane commented Aug 7, 2024

/reopen

It is still needed by the new external-provisioner. openshift/csi-external-provisioner#104 fails because of topology.

@openshift-ci openshift-ci bot reopened this Aug 7, 2024
Copy link
Contributor

openshift-ci bot commented Aug 7, 2024

@jsafrane: Reopened this PR.

In response to this:

/reopen

It is still needed by the new external-provisioner. openshift/csi-external-provisioner#104 fails because of topology.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@RomanBednar
Copy link
Contributor

RomanBednar commented Aug 7, 2024

/label docs-approved
/label px-approved
/lgtm
/retitle STOR-1593: Disable toplogy feature explicitly

@openshift-ci openshift-ci bot changed the title Disable toplogy feature explicitly STOR-1593: Disable toplogy feature explicitly Aug 7, 2024
@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Aug 7, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 7, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 7, 2024

@gnufied: This pull request references STOR-1593 which is a valid jira issue.

In response to this:

fixes https://issues.redhat.com/browse/OCPBUGS-37455

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@duanwei33
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Aug 7, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 7, 2024

@gnufied: This pull request references STOR-1593 which is a valid jira issue.

In response to this:

fixes https://issues.redhat.com/browse/OCPBUGS-37455

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Aug 7, 2024

@gnufied: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 2c3a7ba into openshift:master Aug 7, 2024
11 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-vmware-vsphere-csi-driver-operator
This PR has been included in build ose-vmware-vsphere-csi-driver-operator-container-v4.18.0-202408071445.p0.g2c3a7ba.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants