-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STOR-1593: Disable toplogy feature explicitly #241
STOR-1593: Disable toplogy feature explicitly #241
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gnufied The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/payload-job periodic-ci-openshift-release-master-nightly-4.17-e2e-vsphere-ovn-csi |
@gnufied: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5ef27d30-49d0-11ef-923b-180448ead2bb-0 |
@gnufied: This pull request references Jira Issue OCPBUGS-37455, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@gnufied: This pull request references Jira Issue OCPBUGS-37455, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/retest-required |
1 similar comment
/retest-required |
While this fixes CSI volume provisioning issue. There are some other weirdness going on, which is causing specifically in-tree PVs to fail to delete with error:
|
/lgtm cancel |
/retitle Disable toplogy feature explicitly I'm un-linking this PR from OCPBUGS-37455 - we fixed that bug by reverting external-provisioner rebase. |
@gnufied: No Jira issue is referenced in the title of this pull request. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/reopen It is still needed by the new external-provisioner. openshift/csi-external-provisioner#104 fails because of topology. |
@jsafrane: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/label docs-approved |
@gnufied: This pull request references STOR-1593 which is a valid jira issue. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/label qe-approved |
@gnufied: This pull request references STOR-1593 which is a valid jira issue. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@gnufied: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
[ART PR BUILD NOTIFIER] Distgit: ose-vmware-vsphere-csi-driver-operator |
fixes https://issues.redhat.com/browse/OCPBUGS-37455