-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-36127: Bump github.com/hashicorp/go-retryablehttp from 0.7.0 to 0.7.7 #960
OCPBUGS-36127: Bump github.com/hashicorp/go-retryablehttp from 0.7.0 to 0.7.7 #960
Conversation
Bumps [github.com/hashicorp/go-retryablehttp](https://github.com/hashicorp/go-retryablehttp) from 0.7.0 to 0.7.7. - [Changelog](https://github.com/hashicorp/go-retryablehttp/blob/main/CHANGELOG.md) - [Commits](hashicorp/go-retryablehttp@v0.7.0...v0.7.7) --- updated-dependencies: - dependency-name: github.com/hashicorp/go-retryablehttp dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
/approve |
The CI here is not happy can you please take a look. |
right please take a look there is a problem with the go version in 4.12 with this change
there is a need to fix that before we can merge |
/jira refresh |
@vrindle: No Jira issue is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@vrindle: This pull request references Jira Issue OCPBUGS-36127, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@vrindle: This pull request references Jira Issue OCPBUGS-36127, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/label cherry-pick-approved |
/lgtm |
/label backport-risk-assessed |
/test ci/prow/controllers |
@bn222: The specified target(s) for
The following commands are available to trigger optional jobs:
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@bn222: The specified target(s) for
The following commands are available to trigger optional jobs:
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@bn222: Overrode contexts on behalf of bn222: ci/prow/pkg In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test ci/prow/controllers |
@vrindle: The specified target(s) for
The following commands are available to trigger optional jobs:
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test controllers |
/jira refresh |
@vrindle: This pull request references Jira Issue OCPBUGS-36127, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/override controllers |
@vrindle: vrindle unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/jira refresh |
@vrindle: This pull request references Jira Issue OCPBUGS-36127, which is valid. 7 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/test controllers |
Makefile
Outdated
@@ -131,7 +131,7 @@ kustomize: ## Download kustomize locally if necessary. | |||
|
|||
ENVTEST = $(shell pwd)/bin/setup-envtest | |||
envtest: ## Download envtest-setup locally if necessary. | |||
$(call go-get-tool,$(ENVTEST),sigs.k8s.io/controller-runtime/tools/setup-envtest@latest) | |||
$(call go-install-tool,$(ENVTEST),sigs.k8s.io/controller-runtime/tools/setup-envtest@release-0.16) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is no go-install-tool
function in 4.12 makefile. can you try
$(call go-install-tool,$(ENVTEST),sigs.k8s.io/controller-runtime/tools/[email protected]) | |
$(call go-get-tool,$(ENVTEST),sigs.k8s.io/controller-runtime/tools/[email protected]) |
4b8d48f
to
f0d05e2
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bn222, vrindle, wizhaoredhat, zeeke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
83b800f
into
openshift:release-4.12
@vrindle: Jira Issue OCPBUGS-36127: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-36127 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[ART PR BUILD NOTIFIER] Distgit: sriov-network-config-daemon |
[ART PR BUILD NOTIFIER] Distgit: sriov-network-webhook |
[ART PR BUILD NOTIFIER] Distgit: sriov-network-operator |
Bumps github.com/hashicorp/go-retryablehttp from 0.7.0 to 0.7.7.
updated-dependencies: