Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-36127: Bump github.com/hashicorp/go-retryablehttp from 0.7.0 to 0.7.7 #960

Conversation

vrindle
Copy link
Contributor

@vrindle vrindle commented Jul 8, 2024

Bumps github.com/hashicorp/go-retryablehttp from 0.7.0 to 0.7.7.


updated-dependencies:

  • dependency-name: github.com/hashicorp/go-retryablehttp dependency-type: direct:production ...

Bumps [github.com/hashicorp/go-retryablehttp](https://github.com/hashicorp/go-retryablehttp) from 0.7.0 to 0.7.7.
- [Changelog](https://github.com/hashicorp/go-retryablehttp/blob/main/CHANGELOG.md)
- [Commits](hashicorp/go-retryablehttp@v0.7.0...v0.7.7)

---
updated-dependencies:
- dependency-name: github.com/hashicorp/go-retryablehttp
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@vrindle vrindle changed the title Bump github.com/hashicorp/go-retryablehttp from 0.7.0 to 0.7.7 [OCPBUGS-36127] Bump github.com/hashicorp/go-retryablehttp from 0.7.0 to 0.7.7 Jul 8, 2024
@wizhaoredhat
Copy link
Contributor

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2024
@SchSeba
Copy link
Contributor

SchSeba commented Jul 14, 2024

The CI here is not happy can you please take a look.
also is it a cherry-pick from other versions?
is it a cherry-pcik from the u/s repo?

@vrindle
Copy link
Contributor Author

vrindle commented Jul 16, 2024

@SchSeba it is a cherry-pick from u/s. In other branches in the d/s it was included in this PR: #954

@SchSeba
Copy link
Contributor

SchSeba commented Jul 17, 2024

right please take a look there is a problem with the go version in 4.12 with this change

/go/src/github.com/openshift/sriov-network-operator/bin/controller-gen object:headerFile="hack/boilerplate.go.txt" paths="./..."
go vet ./...
/go/src/github.com/openshift/sriov-network-operator/bin/controller-gen "crd:crdVersions={v1}" webhook paths="./..." output:crd:artifacts:config=./config/crd/bases
cp ./config/crd/bases/* ./deployment/sriov-network-operator/crds/
go: creating new go.mod: module tmp
Downloading sigs.k8s.io/controller-runtime/tools/setup-envtest@latest
go: downloading sigs.k8s.io/controller-runtime/tools/setup-envtest v0.0.0-20240707215[50](https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_sriov-network-operator/960/pull-ci-openshift-sriov-network-operator-release-4.12-api/1810238230025474048#1:build-log.txt%3A50)1-3299760ea46c
go: downloading sigs.k8s.io/controller-runtime v0.18.4
go: sigs.k8s.io/controller-runtime/tools/setup-envtest@latest (in sigs.k8s.io/controller-runtime/tools/[email protected]): go.mod:3: invalid go version '1.22.0': must match format 1.23

there is a need to fix that before we can merge

@vrindle
Copy link
Contributor Author

vrindle commented Aug 9, 2024

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@vrindle: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vrindle vrindle changed the title [OCPBUGS-36127] Bump github.com/hashicorp/go-retryablehttp from 0.7.0 to 0.7.7 OCPBUGS-36127: Bump github.com/hashicorp/go-retryablehttp from 0.7.0 to 0.7.7 Aug 9, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 9, 2024
@openshift-ci-robot
Copy link
Contributor

@vrindle: This pull request references Jira Issue OCPBUGS-36127, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
  • expected Jira Issue OCPBUGS-36127 to depend on a bug targeting a version in 4.13.0, 4.13.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bumps github.com/hashicorp/go-retryablehttp from 0.7.0 to 0.7.7.


updated-dependencies:

  • dependency-name: github.com/hashicorp/go-retryablehttp dependency-type: direct:production ...

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Aug 9, 2024
@vrindle
Copy link
Contributor Author

vrindle commented Aug 9, 2024

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@vrindle: This pull request references Jira Issue OCPBUGS-36127, which is invalid:

  • expected dependent Jira Issue OCPBUGS-36128 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@yingwang-0320
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 9, 2024
@bn222
Copy link
Contributor

bn222 commented Aug 9, 2024

/lgtm

@bn222
Copy link
Contributor

bn222 commented Aug 9, 2024

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Aug 9, 2024
@bn222
Copy link
Contributor

bn222 commented Aug 9, 2024

/test ci/prow/controllers

Copy link
Contributor

openshift-ci bot commented Aug 9, 2024

@bn222: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test api
  • /test ci-index-sriov-network-operator-bundle
  • /test controllers
  • /test gofmt
  • /test images
  • /test operator-e2e
  • /test pkg

The following commands are available to trigger optional jobs:

  • /test e2e-openstack-nfv
  • /test e2e-openstack-nfv-hwoffload

Use /test all to run all jobs.

In response to this:

/test ci/prow/pkg

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Aug 9, 2024

@bn222: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test api
  • /test ci-index-sriov-network-operator-bundle
  • /test controllers
  • /test gofmt
  • /test images
  • /test operator-e2e
  • /test pkg

The following commands are available to trigger optional jobs:

  • /test e2e-openstack-nfv
  • /test e2e-openstack-nfv-hwoffload

Use /test all to run all jobs.

In response to this:

/test ci/prow/controllers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Aug 9, 2024

@bn222: Overrode contexts on behalf of bn222: ci/prow/pkg

In response to this:

/override ci/prow/pkg

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@vrindle
Copy link
Contributor Author

vrindle commented Aug 9, 2024

/test ci/prow/controllers

Copy link
Contributor

openshift-ci bot commented Aug 9, 2024

@vrindle: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test api
  • /test ci-index-sriov-network-operator-bundle
  • /test controllers
  • /test gofmt
  • /test images
  • /test operator-e2e
  • /test pkg

The following commands are available to trigger optional jobs:

  • /test e2e-openstack-nfv
  • /test e2e-openstack-nfv-hwoffload

Use /test all to run all jobs.

In response to this:

/test ci/prow/controllers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@vrindle
Copy link
Contributor Author

vrindle commented Aug 9, 2024

/test controllers

@vrindle
Copy link
Contributor Author

vrindle commented Aug 9, 2024

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@vrindle: This pull request references Jira Issue OCPBUGS-36127, which is invalid:

  • expected dependent Jira Issue OCPBUGS-36128 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vrindle
Copy link
Contributor Author

vrindle commented Aug 9, 2024

/override controllers

Copy link
Contributor

openshift-ci bot commented Aug 9, 2024

@vrindle: vrindle unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers.

In response to this:

/override controllers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@vrindle
Copy link
Contributor Author

vrindle commented Aug 9, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Aug 9, 2024
@openshift-ci-robot
Copy link
Contributor

@vrindle: This pull request references Jira Issue OCPBUGS-36127, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.z) matches configured target version for branch (4.12.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-36128 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-36128 targets the "4.13.z" version, which is one of the valid target versions: 4.13.0, 4.13.z
  • bug has dependents

Requesting review from QA contact:
/cc @zhaozhanqi

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Aug 9, 2024
@openshift-ci openshift-ci bot requested a review from zhaozhanqi August 9, 2024 10:11
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 6af0389 and 2 for PR HEAD 4b8d48f in total

@vrindle
Copy link
Contributor Author

vrindle commented Aug 9, 2024

/test controllers

Makefile Outdated
@@ -131,7 +131,7 @@ kustomize: ## Download kustomize locally if necessary.

ENVTEST = $(shell pwd)/bin/setup-envtest
envtest: ## Download envtest-setup locally if necessary.
$(call go-get-tool,$(ENVTEST),sigs.k8s.io/controller-runtime/tools/setup-envtest@latest)
$(call go-install-tool,$(ENVTEST),sigs.k8s.io/controller-runtime/tools/setup-envtest@release-0.16)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no go-install-tool function in 4.12 makefile. can you try

Suggested change
$(call go-install-tool,$(ENVTEST),sigs.k8s.io/controller-runtime/tools/[email protected])
$(call go-get-tool,$(ENVTEST),sigs.k8s.io/controller-runtime/tools/[email protected])

@vrindle vrindle force-pushed the bump-go-retryablehttp-4.12.0 branch from 4b8d48f to f0d05e2 Compare August 9, 2024 10:54
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 9, 2024
@zeeke
Copy link
Contributor

zeeke commented Aug 9, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 9, 2024
Copy link
Contributor

openshift-ci bot commented Aug 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bn222, vrindle, wizhaoredhat, zeeke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 83b800f into openshift:release-4.12 Aug 9, 2024
8 of 10 checks passed
@openshift-ci-robot
Copy link
Contributor

@vrindle: Jira Issue OCPBUGS-36127: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-36127 has been moved to the MODIFIED state.

In response to this:

Bumps github.com/hashicorp/go-retryablehttp from 0.7.0 to 0.7.7.


updated-dependencies:

  • dependency-name: github.com/hashicorp/go-retryablehttp dependency-type: direct:production ...

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: sriov-network-config-daemon
This PR has been included in build sriov-network-config-daemon-container-v4.12.0-202408091241.p0.g83b800f.assembly.stream.el8.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: sriov-network-webhook
This PR has been included in build sriov-network-webhook-container-v4.12.0-202408091241.p0.g83b800f.assembly.stream.el8.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: sriov-network-operator
This PR has been included in build sriov-network-operator-container-v4.12.0-202408091241.p0.g83b800f.assembly.stream.el8.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.