-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bad merge in env.sh for OVS_CNI_IMAGE variable #926
Fix bad merge in env.sh for OVS_CNI_IMAGE variable #926
Conversation
Hi @thom311. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
d6b88bb
to
a18a563
Compare
/ok-to-test @thom311 thanks for fixing this! |
/retest |
This also leads to envsubst replacing "operator.yaml" with - name: OVS_CNI_IMAGE value: {OVS_CNI_IMAGE:-quay.io/kubevirt/ovs-cni-plugin@sha256:7ec7e51e66e42501b79cc97eba8871b9b2ed5328fbcfce2160352e3d44fee852} This leads then to an error: + oc apply -n openshift-sriov-network-operator --validate=false -f - Error from server (BadRequest): error when creating "STDIN": Deployment in version "v1" cannot be handled as a Deployment: json: cannot unmarshal object into Go struct field EnvVar.spec.template.spec.containers.env.value of type string Fixes: c77576f ('Merge branch 'master' into sync-2024-04-09')
a18a563
to
2ead688
Compare
Sorry, there was a spelling error in the commit message. Force Repushed. |
@thom311: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bn222, thom311, zeeke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3b79f5e
into
openshift:master
[ART PR BUILD NOTIFIER] This PR has been included in build sriov-network-config-daemon-container-v4.17.0-202404220616.p0.g3b79f5e.assembly.stream.el9 for distgit sriov-network-config-daemon. |
[ART PR BUILD NOTIFIER] This PR has been included in build sriov-network-operator-container-v4.17.0-202404220616.p0.g3b79f5e.assembly.stream.el9 for distgit sriov-network-operator. |
This also leads to a failure during deploy:
Fixes: c77576f ('Merge branch 'master' into sync-2024-04-09')