Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad merge in env.sh for OVS_CNI_IMAGE variable #926

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

thom311
Copy link
Contributor

@thom311 thom311 commented Apr 19, 2024

This also leads to a failure during deploy:

+ oc apply -n openshift-sriov-network-operator --validate=false -f -
Error from server (BadRequest): error when creating "STDIN": Deployment in version "v1" cannot be handled as a Deployment: json: cannot unmarshal object into Go struct field EnvVar.spec.template.spec.containers.env.value of type string

Fixes: c77576f ('Merge branch 'master' into sync-2024-04-09')

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 19, 2024
Copy link
Contributor

openshift-ci bot commented Apr 19, 2024

Hi @thom311. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from bn222 and dougbtv April 19, 2024 05:46
@thom311 thom311 force-pushed the th/fix-env-variable branch from d6b88bb to a18a563 Compare April 19, 2024 05:52
@zeeke
Copy link
Contributor

zeeke commented Apr 19, 2024

/ok-to-test
/lgtm

@thom311 thanks for fixing this!

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 19, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2024
@zeeke
Copy link
Contributor

zeeke commented Apr 19, 2024

/retest

This also leads to envsubst replacing "operator.yaml" with

  - name: OVS_CNI_IMAGE
    value: {OVS_CNI_IMAGE:-quay.io/kubevirt/ovs-cni-plugin@sha256:7ec7e51e66e42501b79cc97eba8871b9b2ed5328fbcfce2160352e3d44fee852}

This leads then to an error:

  + oc apply -n openshift-sriov-network-operator --validate=false -f -
  Error from server (BadRequest): error when creating "STDIN": Deployment in version "v1" cannot be handled as a Deployment: json: cannot unmarshal object into Go struct field EnvVar.spec.template.spec.containers.env.value of type string

Fixes: c77576f ('Merge branch 'master' into sync-2024-04-09')
@thom311 thom311 force-pushed the th/fix-env-variable branch from a18a563 to 2ead688 Compare April 19, 2024 14:45
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2024
@thom311
Copy link
Contributor Author

thom311 commented Apr 19, 2024

New changes are detected. LGTM label has been removed.

Sorry, there was a spelling error in the commit message. Force Repushed.

Copy link
Contributor

openshift-ci bot commented Apr 19, 2024

@thom311: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-nfv-hwoffload 2ead688 link false /test e2e-openstack-nfv-hwoffload
ci/prow/e2e-openstack-nfv 2ead688 link false /test e2e-openstack-nfv
ci/prow/security 2ead688 link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zeeke
Copy link
Contributor

zeeke commented Apr 22, 2024

/lgtm

@bn222 @SchSeba PTAL

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2024
@bn222
Copy link
Contributor

bn222 commented Apr 22, 2024

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Apr 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bn222, thom311, zeeke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 22, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 3b79f5e into openshift:master Apr 22, 2024
9 of 12 checks passed
@thom311 thom311 deleted the th/fix-env-variable branch April 22, 2024 08:50
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build sriov-network-config-daemon-container-v4.17.0-202404220616.p0.g3b79f5e.assembly.stream.el9 for distgit sriov-network-config-daemon.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build sriov-network-operator-container-v4.17.0-202404220616.p0.g3b79f5e.assembly.stream.el9 for distgit sriov-network-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants