Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-25924: envtest: Stick to a specific setup-envtest version #878

Merged

Conversation

zeeke
Copy link
Contributor

@zeeke zeeke commented Jan 2, 2024

Using @latest for tools dependecies produces unrepeatable builds which might break at any point in time. This is particularly important when maintaining released versions which need a backport fix.

Note: At the moment is not possible to reference the package sigs.k8s.io/controller-runtime/tools/setup-envtest with a specific version:

go: sigs.k8s.io/controller-runtime/tools/[email protected]: module sigs.k8s.io/[email protected] found, but does not contain package sigs.k8s.io/controller-runtime/tools/setup-envtest

See kubernetes-sigs/kubebuilder#2480

Ref:
#849

Using `@latest` for tools dependecies produces unrepeatable
builds which might break at any point in time. This is
particularly important when maintaining released versions
which need a backport fix.

Note: At the moment is not possible to reference the package
`sigs.k8s.io/controller-runtime/tools/setup-envtest` with a specific
version:

```
go: sigs.k8s.io/controller-runtime/tools/[email protected]: module sigs.k8s.io/[email protected] found, but does not contain package sigs.k8s.io/controller-runtime/tools/setup-envtest
```

See kubernetes-sigs/kubebuilder#2480

Ref:
openshift#849
Signed-off-by: Andrea Panattoni <[email protected]>
@zeeke
Copy link
Contributor Author

zeeke commented Jan 2, 2024

/jira cherrypick OCPBUGS-25853

@openshift-ci-robot
Copy link
Contributor

@zeeke: Jira Issue OCPBUGS-25853 has been cloned as Jira Issue OCPBUGS-25924. Will retitle bug to link to clone.
/retitle OCPBUGS-25924: envtest: Stick to a specific setup-envtest version

In response to this:

/jira cherrypick OCPBUGS-25853

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title envtest: Stick to a specific setup-envtest version OCPBUGS-25924: envtest: Stick to a specific setup-envtest version Jan 2, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 2, 2024
@openshift-ci-robot
Copy link
Contributor

@zeeke: This pull request references Jira Issue OCPBUGS-25924, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-25853 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-25853 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • bug has dependents

Requesting review from QA contact:
/cc @zhaozhanqi

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Using @latest for tools dependecies produces unrepeatable builds which might break at any point in time. This is particularly important when maintaining released versions which need a backport fix.

Note: At the moment is not possible to reference the package sigs.k8s.io/controller-runtime/tools/setup-envtest with a specific version:

go: sigs.k8s.io/controller-runtime/tools/[email protected]: module sigs.k8s.io/[email protected] found, but does not contain package sigs.k8s.io/controller-runtime/tools/setup-envtest

See kubernetes-sigs/kubebuilder#2480

Ref:
#849

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jan 2, 2024
@SchSeba
Copy link
Contributor

SchSeba commented Jan 2, 2024

/lgtm
/approve
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jan 2, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 2, 2024
Copy link
Contributor

openshift-ci bot commented Jan 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SchSeba, zeeke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 2, 2024
Copy link
Contributor

openshift-ci bot commented Jan 2, 2024

@zeeke: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-nfv 8d9da0a link false /test e2e-openstack-nfv

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zhaozhanqi
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 9, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 00e0317 into openshift:release-4.15 Jan 9, 2024
@openshift-ci-robot
Copy link
Contributor

@zeeke: Jira Issue OCPBUGS-25924: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-25924 has been moved to the MODIFIED state.

In response to this:

Using @latest for tools dependecies produces unrepeatable builds which might break at any point in time. This is particularly important when maintaining released versions which need a backport fix.

Note: At the moment is not possible to reference the package sigs.k8s.io/controller-runtime/tools/setup-envtest with a specific version:

go: sigs.k8s.io/controller-runtime/tools/[email protected]: module sigs.k8s.io/[email protected] found, but does not contain package sigs.k8s.io/controller-runtime/tools/setup-envtest

See kubernetes-sigs/kubebuilder#2480

Ref:
#849

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build sriov-network-webhook-container-v4.15.0-202401090250.p0.g00e0317.assembly.stream for distgit sriov-network-webhook.
All builds following this will include this PR.

@zeeke
Copy link
Contributor Author

zeeke commented Jan 9, 2024

/cherrypick release-4.14

@openshift-cherrypick-robot

@zeeke: new pull request created: #881

In response to this:

/cherrypick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.