-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-25924: envtest: Stick to a specific setup-envtest version #878
OCPBUGS-25924: envtest: Stick to a specific setup-envtest version #878
Conversation
Using `@latest` for tools dependecies produces unrepeatable builds which might break at any point in time. This is particularly important when maintaining released versions which need a backport fix. Note: At the moment is not possible to reference the package `sigs.k8s.io/controller-runtime/tools/setup-envtest` with a specific version: ``` go: sigs.k8s.io/controller-runtime/tools/[email protected]: module sigs.k8s.io/[email protected] found, but does not contain package sigs.k8s.io/controller-runtime/tools/setup-envtest ``` See kubernetes-sigs/kubebuilder#2480 Ref: openshift#849 Signed-off-by: Andrea Panattoni <[email protected]>
/jira cherrypick OCPBUGS-25853 |
@zeeke: Jira Issue OCPBUGS-25853 has been cloned as Jira Issue OCPBUGS-25924. Will retitle bug to link to clone. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@zeeke: This pull request references Jira Issue OCPBUGS-25924, which is valid. The bug has been moved to the POST state. 6 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SchSeba, zeeke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@zeeke: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/label cherry-pick-approved |
@zeeke: Jira Issue OCPBUGS-25924: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-25924 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[ART PR BUILD NOTIFIER] This PR has been included in build sriov-network-webhook-container-v4.15.0-202401090250.p0.g00e0317.assembly.stream for distgit sriov-network-webhook. |
/cherrypick release-4.14 |
@zeeke: new pull request created: #881 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Using
@latest
for tools dependecies produces unrepeatable builds which might break at any point in time. This is particularly important when maintaining released versions which need a backport fix.Note: At the moment is not possible to reference the package
sigs.k8s.io/controller-runtime/tools/setup-envtest
with a specific version:See kubernetes-sigs/kubebuilder#2480
Ref:
#849