[release-4.15] OCPBUGS-25407: Fix config daemon annotation override #874
Conversation
A downstream merge [1][2] overrode the annotations in the config daemonset. This resulted in he sriov-network-config-daemon pod missing the `target.workload.openshift.io/management` annotation which led to the pod not being pinned to the management cores when workload partitioning is enabled. This is a downstream-only patch. [1] openshift#868 [2] commit 0f17753 Signed-off-by: Carlos Goncalves <[email protected]>
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-24231 has been cloned as Jira Issue OCPBUGS-25407. Will retitle bug to link to clone. WARNING: Failed to update the target version for the clone. Please update the target version manually. Full error below: Full error message.
Number value expected as the Sprint id.: request failed. Please analyze the request body for more details. Status code: 400:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
changed the title
openshift-ci-robot
added
jira/severity-important
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-25407, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
openshift-ci
bot
added
the
backport-risk-assessed
openshift-ci
bot
assigned anuragthehatter, asood-rh, huiran0826, jechen0648, mffiedler, qiowang721, rbbratta, weliang1 and yingwang-0320
|
/jira refresh |
|
@cgoncalves: This pull request references Jira Issue OCPBUGS-25407, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@cgoncalves: This pull request references Jira Issue OCPBUGS-25407, which is valid. The bug has been moved to the POST state. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: dgonyier. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@zeeke please approve. |
|
/label cherry-pick-approved |
|
@zeeke: Can not set label cherry-pick-approved: Must be member in one of these teams: [] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: openshift-cherrypick-robot, SchSeba, zeeke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/label cherry-pick-approved |
openshift-ci
bot
added
the
cherry-pick-approved
openshift-merge-bot
bot
merged commit 5042b58
into
openshift:release-4.15
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-25407: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-25407 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build sriov-network-operator-container-v4.15.0-202312210131.p0.g5042b58.assembly.stream for distgit sriov-network-operator. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build sriov-network-webhook-container-v4.15.0-202312210131.p0.g5042b58.assembly.stream for distgit sriov-network-webhook. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build sriov-network-config-daemon-container-v4.15.0-202312210131.p0.g5042b58.assembly.stream for distgit sriov-network-config-daemon. |
This is an automated cherry-pick of #873
/assign cgoncalves