OCPBUGS-23548: Hash contents of cm instead of using resource version #864
Conversation
Previously, the code was using the resource version as a short-hand to check if the contents of the cm has changed. However, the resource version can change for any reason without any changes to the actual data inside the cm. For example, when etcd encryption is enabled, and key rotation occurs, the version will change. Instead, use a unique hash that depends solely on the contents of the cm to track the "version" of the DpConfig. Signed-off-by: Balazs Nemeth <[email protected]>
Signed-off-by: Balazs Nemeth <[email protected]>
openshift-ci-robot
added
jira/severity-important
|
@bn222: This pull request references Jira Issue OCPBUGS-23548, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
approved
|
/jira-refresh |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@zshi-redhat: This pull request references Jira Issue OCPBUGS-23548, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
@bn222: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bn222, wizhaoredhat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@bn222: Jira Issue OCPBUGS-23548: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-23548 has been moved to the MODIFIED state. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build sriov-network-config-daemon-container-v4.15.0-202311231531.p0.g90d0d9d.assembly.stream for distgit sriov-network-config-daemon. |
No description provided.