Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dsonly: Allow config-daemon to send k8s events #861

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

zeeke
Copy link
Contributor

@zeeke zeeke commented Nov 8, 2023

Downstream changes for bundles related to
k8snetworkplumbingwg/sriov-network-operator@4d153f8

Refs:

Without the permission, configd-daemon logs show errors like:

E1108 11:19:01.415311   14200 event.go:280] Server rejected event '&v1.Event{TypeMeta:v1.TypeMeta{Kind:"", APIVersion:""}, ObjectMeta:v1.ObjectMeta{Name:"cnfdd5.clus2.t5g.lab.eng.bos.redhat.com.1795a1ce34116d89", GenerateName:"", Namespace:"openshift-sriov-network-operator", SelfLink:"", UID:"", ResourceVersion:"", Generation:0, CreationTimestamp:time.Date(1, time.January, 1, 0, 0, 0, 0, time.UTC), DeletionTimestamp:<nil>, DeletionGracePeriodSeconds:(*int64)(nil), Labels:map[string]string(nil), Annotations:map[string]string(nil), OwnerReferences:[]v1.OwnerReference(nil), Finalizers:[]string(nil), ManagedFields:[]v1.ManagedFieldsEntry(nil)}, InvolvedObject:v1.ObjectReference{Kind:"SriovNetworkNodeState", Namespace:"openshift-sriov-network-operator", Name:"cnfdd5.clus2.t5g.lab.eng.bos.redhat.com", UID:"85e98d18-074e-4ca8-abe2-88f1dbbb2377", APIVersion:"sriovnetwork.openshift.io/v1", ResourceVersion:"10027967", FieldPath:""}, Reason:"ConfigDaemonStart", Message:"Config Daemon starting", Source:v1.EventSource{Component:"config-daemon", Host:""}, FirstTimestamp:time.Date(2023, time.November, 8, 11, 19, 1, 411122569, time.Local), LastTimestamp:time.Date(2023, time.November, 8, 11, 19, 1, 411122569, time.Local), Count:1, Type:"Normal", EventTime:time.Date(1, time.January, 1, 0, 0, 0, 0, time.UTC), Series:(*v1.EventSeries)(nil), Action:"", Related:(*v1.ObjectReference)(nil), ReportingController:"", ReportingInstance:""}': 'events is forbidden: User "system:serviceaccount:openshift-sriov-network-operator:sriov-network-config-daemon" cannot create resource "events" in API group "" in the namespace "openshift-sriov-network-operator"' (will not retry!)

Also run runmake -f Makefile.bundle bundle to align manifests

/cc @mlguerrero12

@openshift-ci openshift-ci bot requested review from bn222 and zshi-redhat November 8, 2023 11:46
@mlguerrero12
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2023
Downstream changes for bundles related to
k8snetworkplumbingwg/sriov-network-operator@4d153f8

run `make -f Makefile.bundle bundle` to align manifests.

Signed-off-by: Andrea Panattoni <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2023
Copy link
Contributor

openshift-ci bot commented Nov 24, 2023

@zeeke: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-nfv-hwoffload 7c2f779 link false /test e2e-openstack-nfv-hwoffload

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zeeke
Copy link
Contributor Author

zeeke commented Nov 27, 2023

@SchSeba @bn222 Please take a look when you have time.

@SchSeba
Copy link
Contributor

SchSeba commented Nov 27, 2023

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2023
Copy link
Contributor

openshift-ci bot commented Nov 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mlguerrero12, SchSeba, zeeke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit bd14743 into openshift:master Nov 27, 2023
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build sriov-network-config-daemon-container-v4.15.0-202311271350.p0.gbd14743.assembly.stream for distgit sriov-network-config-daemon.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build sriov-network-webhook-container-v4.15.0-202311271350.p0.gbd14743.assembly.stream for distgit sriov-network-webhook.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants