Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-23059: [release-4.13]: SriovNetwork, SriovIBNetwork, react on namespace creation #860

Merged
merged 2 commits into from
Dec 21, 2023
Merged

OCPBUGS-23059: [release-4.13]: SriovNetwork, SriovIBNetwork, react on namespace creation #860

merged 2 commits into from
Dec 21, 2023

Conversation

zeeke
Copy link
Contributor

@zeeke zeeke commented Nov 8, 2023

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 8, 2023
@zeeke zeeke changed the base branch from master to release-4.13 November 8, 2023 10:45
@zeeke
Copy link
Contributor Author

zeeke commented Nov 8, 2023

/jira cherrypick OCPBUGS-19440

@openshift-ci-robot
Copy link
Contributor

@zeeke: Jira Issue OCPBUGS-19440 has been cloned as Jira Issue OCPBUGS-23059. Will retitle bug to link to clone.
/retitle OCPBUGS-23059: [release-4.13]: SriovNetwork, SriovIBNetwork, react on namespace creation

In response to this:

/jira cherrypick OCPBUGS-19440

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.13]: SriovNetwork, SriovIBNetwork, react on namespace creation OCPBUGS-23059: [release-4.13]: SriovNetwork, SriovIBNetwork, react on namespace creation Nov 8, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Nov 8, 2023
@openshift-ci-robot
Copy link
Contributor

@zeeke: This pull request references Jira Issue OCPBUGS-23059, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.z) matches configured target version for branch (4.13.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-19440 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-19440 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0, 4.14.z
  • bug has dependents

Requesting review from QA contact:
/cc @zhaozhanqi

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

4.13 Backport of:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Nov 8, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 8, 2023
zeeke added 2 commits November 8, 2023 14:29
@zeeke
SriovIBetwork: react on namespace creation
edbcb7a 
Apply the same namespace reaction as the SriovNetwork

Signed-off-by: Andrea Panattoni <[email protected]>
@zeeke
SriovNetwork: react on namespace creation
a1027f8 
If a user creates an SriovNetwork with a network namespace
that doesn't exist, retrying reconciling with an exponential
backoff is not efficient, as the routing will fail until the namespace
is created.

This patch makes the controller watch Namespace resource
creation and reconcile the related SriovNetworks if needed.

Signed-off-by: Andrea Panattoni <[email protected]>
@zeeke zeeke force-pushed the 4.13-ocpbugs-8266 branch from 6da2f62 to a1027f8 Compare November 8, 2023 13:29
@zeeke
Copy link
Contributor Author

zeeke commented Nov 8, 2023

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 8, 2023 •
edited
Loading

@zeeke: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-nfv-hwoffload 6da2f62 link false /test e2e-openstack-nfv-hwoffload
ci/prow/e2e-openstack-nfv 6da2f62 link false /test e2e-openstack-nfv

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zeeke
Copy link
Contributor Author

zeeke commented Nov 23, 2023

@bn222 @wizhaoredhat @zhaozhanqi Please, take a look at this backport.

4.14 backport PR is:

@wizhaoredhat
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 23, 2023
@zeeke
Copy link
Contributor Author

zeeke commented Dec 12, 2023

@SchSeba @zhaozhanqi Please, take a look at this backport. It needs cherry-pick-approved and backport-risk-assessed labels.

@zhaozhanqi
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 12, 2023
@SchSeba
Copy link
Contributor

SchSeba commented Dec 21, 2023

/lgtm
/approve
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Dec 21, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SchSeba, wizhaoredhat, zeeke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [SchSeba,wizhaoredhat]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit f79d480 into openshift:release-4.13 Dec 21, 2023
8 checks passed
@openshift-ci-robot
Copy link
Contributor

@zeeke: Jira Issue OCPBUGS-23059: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-23059 has been moved to the MODIFIED state.

In response to this:

4.13 Backport of:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build sriov-network-operator-container-v4.13.0-202312211950.p0.gf79d480.assembly.stream for distgit sriov-network-operator.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build sriov-network-webhook-container-v4.13.0-202312211950.p0.gf79d480.assembly.stream for distgit sriov-network-webhook.
All builds following this will include this PR.

@zeeke
Copy link
Contributor Author

zeeke commented Dec 22, 2023

/cherrypick release-4.12

@openshift-cherrypick-robot
Copy link

@zeeke: #860 failed to apply on top of branch "release-4.12":

Applying: SriovIBetwork: react on namespace creation
Using index info to reconstruct a base tree...
M	controllers/sriovibnetwork_controller.go
M	controllers/sriovibnetwork_controller_test.go
M	controllers/suite_test.go
Falling back to patching base and 3-way merge...
Auto-merging controllers/suite_test.go
Auto-merging controllers/sriovibnetwork_controller_test.go
Auto-merging controllers/sriovibnetwork_controller.go
CONFLICT (content): Merge conflict in controllers/sriovibnetwork_controller.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 SriovIBetwork: react on namespace creation
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaozhanqi zhaozhanqi Awaiting requested review from zhaozhanqi

@s1061123 s1061123 Awaiting requested review from s1061123

@SchSeba SchSeba Awaiting requested review from SchSeba

Assignees

@mffiedler mffiedler

@rbbratta rbbratta

@weliang1 weliang1

@anuragthehatter anuragthehatter

@huiran0826 huiran0826

@asood-rh asood-rh

@jechen0648 jechen0648

@yingwang-0320 yingwang-0320

@wizhaoredhat wizhaoredhat

@qiowang721 qiowang721

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.