Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-22907: Match origin image to configured image reference #858

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

ashwindasr
Copy link
Contributor

Since image-references are configured by version for this repo.

@openshift-ci openshift-ci bot requested review from Billy99 and dougbtv November 1, 2023 13:47
@dougbtv
Copy link
Member

dougbtv commented Nov 1, 2023

/approve
/lgtm
/label backport-risk-assessed

@dougbtv
Copy link
Member

dougbtv commented Nov 1, 2023

/approve

@dougbtv
Copy link
Member

dougbtv commented Nov 1, 2023

/lgtm

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Nov 1, 2023
@dougbtv
Copy link
Member

dougbtv commented Nov 1, 2023

/label backport-risk-assessed

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 1, 2023
@zhaozhanqi
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 2, 2023
@ashwindasr
Copy link
Contributor Author

/retest

@zshi-redhat zshi-redhat changed the title Match origin image to configured image reference OCPBUGS-22907: Match origin image to configured image reference Nov 6, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 6, 2023
@openshift-ci-robot
Copy link
Contributor

@ashwindasr: This pull request references Jira Issue OCPBUGS-22907, which is invalid:

  • expected dependent Jira Issue OCPBUGS-22906 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is New instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Since image-references are configured by version for this repo.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zhaozhanqi
Copy link

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 14, 2023
@openshift-ci-robot
Copy link
Contributor

@zhaozhanqi: This pull request references Jira Issue OCPBUGS-22907, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.11.z) matches configured target version for branch (4.11.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-22906 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-22906 targets the "4.12.z" version, which is one of the valid target versions: 4.12.0, 4.12.z
  • bug has dependents

Requesting review from QA contact:
/cc @zhaozhanqi

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from zhaozhanqi November 14, 2023 08:35
@zhaozhanqi
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Nov 14, 2023
@openshift-ci-robot
Copy link
Contributor

@ashwindasr: This pull request references Jira Issue OCPBUGS-22907, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.11.z) matches configured target version for branch (4.11.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-22906 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-22906 targets the "4.12.z" version, which is one of the valid target versions: 4.12.0, 4.12.z
  • bug has dependents

Requesting review from QA contact:
/cc @zhaozhanqi

In response to this:

Since image-references are configured by version for this repo.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 3b09c84 and 2 for PR HEAD ca7287f in total

Copy link
Contributor

openshift-ci bot commented Nov 14, 2023

@ashwindasr: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-nfv ca7287f link false /test e2e-openstack-nfv

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zeeke
Copy link
Contributor

zeeke commented Nov 24, 2023

@SchSeba
Copy link
Contributor

SchSeba commented Nov 27, 2023

/lgtm
/approve
/override ci/prow/api
/override ci/prow/controllers
/override ci/prow/pkg

@SchSeba
Copy link
Contributor

SchSeba commented Nov 27, 2023

the changes are not related to the failing lanes override

Copy link
Contributor

openshift-ci bot commented Nov 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashwindasr, dougbtv, SchSeba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Nov 27, 2023

@SchSeba: Overrode contexts on behalf of SchSeba: ci/prow/api, ci/prow/controllers, ci/prow/pkg

In response to this:

/lgtm
/approve
/override ci/prow/api
/override ci/prow/controllers
/override ci/prow/pkg

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 70bd2d4 into openshift:release-4.11 Nov 27, 2023
4 checks passed
@openshift-ci-robot
Copy link
Contributor

@ashwindasr: Jira Issue OCPBUGS-22907: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-22907 has been moved to the MODIFIED state.

In response to this:

Since image-references are configured by version for this repo.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build sriov-network-operator-container-v4.11.0-202311271107.p0.g70bd2d4.assembly.stream for distgit sriov-network-operator.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build sriov-network-webhook-container-v4.11.0-202311271107.p0.g70bd2d4.assembly.stream for distgit sriov-network-webhook.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.