Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-20211: update version to 4.15 #840

Merged
merged 1 commit into from
Oct 25, 2023
Merged

OCPBUGS-20211: update version to 4.15 #840

merged 1 commit into from
Oct 25, 2023

Conversation

zeeke
Copy link
Contributor

@zeeke zeeke commented Oct 17, 2023

updated references from 4.14 to 4.15 via:

find . -not -path "./vendor*" -type f -print0 | xargs -0 sed -i 's/4\.14/4.15/g'
 make -f Makefile.bundle bundle

cc @wizhaoredhat, @bn222

@openshift-ci openshift-ci bot requested review from bn222 and pliurh October 17, 2023 09:14
@bn222
Copy link
Contributor

bn222 commented Oct 17, 2023

Can you fix some of this manual work? There are places that are hardcoded but we could derive it from a single place where we define the version number.

@zeeke
Copy link
Contributor Author

zeeke commented Oct 17, 2023

Can you fix some of this manual work? There are places that are hardcoded but we could derive it from a single place where we define the version number.

I had a look and I'm not sure where we can improve that, TBH.

Also, this PR images are not doesn't deploying:
sriov-network-operator.log

sriov-network-operator: /lib64/libc.so.6: version `GLIBC_2.32' not found (required by sriov-network-operator)
sriov-network-operator: /lib64/libc.so.6: version `GLIBC_2.34' not found (required by sriov-network-operator)

I'm investigating

@bn222
Copy link
Contributor

bn222 commented Oct 18, 2023

#838

@bn222
Copy link
Contributor

bn222 commented Oct 18, 2023

@zeeke please add OCPBUGS-20211 to the title.

@bn222 bn222 mentioned this pull request Oct 18, 2023
Closed
@zeeke zeeke changed the title update version to 4.15 OCPBUGS-20211: update version to 4.15 Oct 18, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Oct 18, 2023
@openshift-ci-robot
Copy link
Contributor

@zeeke: This pull request references Jira Issue OCPBUGS-20211, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @zhaozhanqi

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

updated references from 4.14 to 4.15 via:

find . -not -path "./vendor*" -type f -print0 | xargs -0 sed -i 's/4\.14/4.15/g'
make -f Makefile.bundle bundle

cc @wizhaoredhat, @bn222

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Oct 18, 2023
@zeeke
Copy link
Contributor Author

zeeke commented Oct 18, 2023

#838

Missed that, sorry

/retest

@openshift-ci openshift-ci bot requested a review from zhaozhanqi October 18, 2023 14:52
@wizhaoredhat
Copy link
Contributor

/retest

@SchSeba
Copy link
Contributor

SchSeba commented Oct 18, 2023

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 18, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 68a8c3a and 2 for PR HEAD c272770 in total

@wizhaoredhat
Copy link
Contributor

/lgtm

@wizhaoredhat
Copy link
Contributor

/retest-required

@zeeke zeeke mentioned this pull request Oct 19, 2023
Closed
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 9e24f2f and 1 for PR HEAD c272770 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 8b3e75a and 0 for PR HEAD c272770 in total

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 23, 2023
@zeeke
update version to 4.15
fbc5bc1 
```
find . -not -path "./vendor*" -type f -print0 | xargs -0 sed -i 's/4\.14/4.15/g'
 make -f Makefile.bundle bundle
```

Signed-off-by: Andrea Panattoni <[email protected]>
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 23, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2023
@wizhaoredhat
Copy link
Contributor

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SchSeba, wizhaoredhat, zeeke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [SchSeba,wizhaoredhat]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 8b3e75a and 2 for PR HEAD fbc5bc1 in total

@zeeke
Copy link
Contributor Author

zeeke commented Oct 24, 2023

/retest

PR

should have fixed the GLIBC problem

@wizhaoredhat
Copy link
Contributor

/retest

1 similar comment
@zeeke
Copy link
Contributor Author

zeeke commented Oct 25, 2023

/retest

@openshift-ci openshift-ci bot merged commit 513daf6 into openshift:master Oct 25, 2023
@openshift-ci-robot
Copy link
Contributor

@zeeke: Jira Issue OCPBUGS-20211: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-20211 has been moved to the MODIFIED state.

In response to this:

updated references from 4.14 to 4.15 via:

find . -not -path "./vendor*" -type f -print0 | xargs -0 sed -i 's/4\.14/4.15/g'
make -f Makefile.bundle bundle

cc @wizhaoredhat, @bn222

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mlguerrero12 mlguerrero12 mentioned this pull request Jan 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bn222 bn222 Awaiting requested review from bn222

@pliurh pliurh Awaiting requested review from pliurh

@zhaozhanqi zhaozhanqi Awaiting requested review from zhaozhanqi

Assignees

@SchSeba SchSeba

@wizhaoredhat wizhaoredhat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zeeke @bn222 @openshift-ci-robot @wizhaoredhat @SchSeba @openshift-merge-robot