Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-18451: [release-4.13] Reduce operator and config-daemon verbosity #817

Merged
merged 5 commits into from
Sep 5, 2023
Merged

OCPBUGS-18451: [release-4.13] Reduce operator and config-daemon verbosity #817

merged 5 commits into from
Sep 5, 2023

Conversation

zeeke
Copy link
Contributor

@zeeke zeeke commented Sep 1, 2023

zeeke added 5 commits September 1, 2023 14:39
@zeeke
Set zap log TimeEncoder
0725082 
Set a TimeEncoder for zap logging system
to have more speaking timestamp.

from `1.6893201844680622e+09` to
`2023-07-14T09:52:29.539392293Z`

Signed-off-by: Andrea Panattoni <[email protected]>
@zeeke
Reduce SriovOperator verbosity
71798fc 
In `renderDevicePluginConfigData()`, avoid
logging the full ResourceList for every resource in the loop.

Avoid logging in helper functions, as they can be invoked in loops.

Signed-off-by: Andrea Panattoni <[email protected]>
@zeeke
Avoid logging devlink warning
468d279 
Devlink mode is not supported by every SR-IOV NIC model.

Signed-off-by: Andrea Panattoni <[email protected]>
@zeeke
Reduce vebosity of config-damon
b8c1305 
Log `getLinkType(): ...` only if LogLevel == 2

Signed-off-by: Andrea Panattoni <[email protected]>
@zeeke
Avoid reconciling policies multiple times
df35d9f 
`SriovNetworkNodePolicy` reconcile function lists all node policies
and updates all SriovNetworkNodeState. Hence there is no need to
resync all of them periodically.

Avoid triggering multiple reconciliations when creating multiple
policies in a row (that is what happens when using yaml files).

Signed-off-by: Andrea Panattoni <[email protected]>
@openshift-ci openshift-ci bot requested review from bn222 and SchSeba September 1, 2023 12:41
@zeeke
Copy link
Contributor Author

zeeke commented Sep 1, 2023

/jira cherrypick OCPBUGS-14499

@openshift-ci-robot
Copy link
Contributor

@zeeke: Jira Issue OCPBUGS-14499 has been cloned as Jira Issue OCPBUGS-18451. Will retitle bug to link to clone.
/retitle OCPBUGS-18451: 4.13 reduce verbosity

In response to this:

/jira cherrypick OCPBUGS-14499

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title 4.13 reduce verbosity OCPBUGS-18451: 4.13 reduce verbosity Sep 1, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 1, 2023
@openshift-ci-robot
Copy link
Contributor

@zeeke: This pull request references Jira Issue OCPBUGS-18451, which is invalid:

  • expected dependent Jira Issue OCPBUGS-14499 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Backport of

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zeeke zeeke changed the title OCPBUGS-18451: 4.13 reduce verbosity OCPBUGS-18451: [release-4.13] Reduce operator and config-daemon verbosisty Sep 1, 2023
@zeeke zeeke changed the title OCPBUGS-18451: [release-4.13] Reduce operator and config-daemon verbosisty OCPBUGS-18451: [release-4.13] Reduce operator and config-daemon verbosity Sep 1, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 1, 2023

@zeeke: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bn222
Copy link
Contributor

bn222 commented Sep 4, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 4, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bn222, zeeke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2023
@zeeke
Copy link
Contributor Author

zeeke commented Sep 4, 2023

@SchSeba please take a look. We need backport-risk-assessed
@zhaozhanqi we also need cherry-pick-approved

@SchSeba
Copy link
Contributor

SchSeba commented Sep 5, 2023

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Sep 5, 2023
@zhaozhanqi
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 5, 2023
@zeeke
Copy link
Contributor Author

zeeke commented Sep 5, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 5, 2023
@openshift-ci-robot
Copy link
Contributor

@zeeke: This pull request references Jira Issue OCPBUGS-18451, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.z) matches configured target version for branch (4.13.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-14499 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-14499 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
  • bug has dependents

Requesting review from QA contact:
/cc @zhaozhanqi

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from zhaozhanqi September 5, 2023 08:16
@zeeke
Copy link
Contributor Author

zeeke commented Sep 5, 2023

/cherrypick release-4.12

@openshift-cherrypick-robot
Copy link

@zeeke: once the present PR merges, I will cherry-pick it on top of release-4.12 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 90836ac into openshift:release-4.13 Sep 5, 2023
@openshift-ci-robot
Copy link
Contributor

@zeeke: Jira Issue OCPBUGS-18451: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-18451 has been moved to the MODIFIED state.

In response to this:

Backport of

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 5, 2023
Merged
@openshift-cherrypick-robot
Copy link

@zeeke: new pull request created: #819

In response to this:

/cherrypick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

SchSeba added a commit to SchSeba/sriov-network-operator that referenced this pull request Dec 18, 2024
@SchSeba
Merge pull request openshift#817 from SchSeba/add_retry_on_delete
cfd160f 
functest: add retry for rdma functionel test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bn222 bn222 Awaiting requested review from bn222

@SchSeba SchSeba Awaiting requested review from SchSeba

@zhaozhanqi zhaozhanqi Awaiting requested review from zhaozhanqi

Assignees

@mffiedler mffiedler

@rbbratta rbbratta

@weliang1 weliang1

@bn222 bn222

@anuragthehatter anuragthehatter

@huiran0826 huiran0826

@asood-rh asood-rh

@jechen0648 jechen0648

@yingwang-0320 yingwang-0320

@qiowang721 qiowang721

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.