Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-2126: Update RBAC files for the network-config-daemon #710

Merged

Conversation

wizhaoredhat
Copy link
Contributor

@wizhaoredhat wizhaoredhat commented Oct 18, 2022

The network-config-daemon needs access to the resource "infrastructures" in the API group "config.openshift.io".

This resource is needed for allowing control plane status detection. This was updated upstream in commit:
"update yaml configuration to allow for control plane status detection" a13b59e

Also ran "make bundle" to update the manifest files.

The network-config-daemon needs access to the resource "infrastructures"
in the API group "config.openshift.io".

Also ran "make bundle" to update the manifest files.
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 18, 2022
@openshift-ci-robot
Copy link
Contributor

@wizhaoredhat: This pull request references Jira Issue OCPBUGS-2126, which is invalid:

  • expected the bug to target the "4.12.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The network-config-daemon needs access to the resource "infrastructures" in the API group "config.openshift.io".

Also ran "make bundle" to update the manifest files.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from s1061123 and SchSeba October 18, 2022 20:15
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2022
@wizhaoredhat
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 18, 2022
@openshift-ci-robot
Copy link
Contributor

@wizhaoredhat: This pull request references Jira Issue OCPBUGS-2126, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.0) matches configured target version for branch (4.12.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @zhaozhanqi

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from zhaozhanqi October 18, 2022 20:15
@wizhaoredhat
Copy link
Contributor Author

/cc @zshi-redhat
/cc @pliurh

@openshift-ci openshift-ci bot requested review from pliurh and zshi-redhat October 18, 2022 20:16
@openshift-ci-robot
Copy link
Contributor

@wizhaoredhat: This pull request references Jira Issue OCPBUGS-2126, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.0) matches configured target version for branch (4.12.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @zhaozhanqi

In response to this:

The network-config-daemon needs access to the resource "infrastructures" in the API group "config.openshift.io".

This resource is needed for allowing control plane status detection. This was updated upstream in commit:
"update yaml configuration to allow for control plane status detection" a13b59e

Also ran "make bundle" to update the manifest files.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2022

@wizhaoredhat: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zeeke zeeke mentioned this pull request Oct 19, 2022
@SchSeba
Copy link
Contributor

SchSeba commented Oct 19, 2022

just comment for a future point

  1. we need to remove the bundle folder from u/s
  2. we still need to maintain the config folder on u/s because the helm chart copy stuff from the config folder

@EmilienM
Copy link
Member

/lgtm

1 similar comment
@dougbtv
Copy link
Member

dougbtv commented Oct 20, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 20, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dougbtv, EmilienM, wizhaoredhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dougbtv,wizhaoredhat]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit fb37fa9 into openshift:master Oct 20, 2022
@openshift-ci-robot
Copy link
Contributor

@wizhaoredhat: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-2126 has been moved to the MODIFIED state.

In response to this:

The network-config-daemon needs access to the resource "infrastructures" in the API group "config.openshift.io".

This resource is needed for allowing control plane status detection. This was updated upstream in commit:
"update yaml configuration to allow for control plane status detection" a13b59e

Also ran "make bundle" to update the manifest files.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wizhaoredhat wizhaoredhat deleted the fix_rbac_OCPBUGS_2126 branch March 14, 2023 17:56
SchSeba pushed a commit to SchSeba/sriov-network-operator that referenced this pull request Jul 1, 2024
Avoid reconfiguring unmentioned DPDK VFs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants