-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-2126: Update RBAC files for the network-config-daemon #710
OCPBUGS-2126: Update RBAC files for the network-config-daemon #710
Conversation
The network-config-daemon needs access to the resource "infrastructures" in the API group "config.openshift.io". Also ran "make bundle" to update the manifest files.
@wizhaoredhat: This pull request references Jira Issue OCPBUGS-2126, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/jira refresh |
@wizhaoredhat: This pull request references Jira Issue OCPBUGS-2126, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @zshi-redhat |
@wizhaoredhat: This pull request references Jira Issue OCPBUGS-2126, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@wizhaoredhat: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
just comment for a future point
|
/lgtm |
1 similar comment
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dougbtv, EmilienM, wizhaoredhat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@wizhaoredhat: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-2126 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Avoid reconfiguring unmentioned DPDK VFs
The network-config-daemon needs access to the resource "infrastructures" in the API group "config.openshift.io".
This resource is needed for allowing control plane status detection. This was updated upstream in commit:
"update yaml configuration to allow for control plane status detection" a13b59e
Also ran "make bundle" to update the manifest files.