Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generates random MAC address when effective virtual function MAC addr… #671

Closed

Conversation

vrindle
Copy link
Contributor

@vrindle vrindle commented Jun 23, 2022

…ess is zero.

This is to set VF effective MAC addresses when the VF effective MAC address is all zero for some vendor NICs.

@openshift-ci openshift-ci bot requested review from pliurh and s1061123 June 23, 2022 00:39
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 23, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vrindle
To complete the pull request process, please assign fabrizio8 after the PR has been reviewed.
You can assign the PR to them by writing /assign @fabrizio8 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 23, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 23, 2022

Hi @vrindle. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vrindle
Copy link
Contributor Author

vrindle commented Jun 23, 2022

Downstream version of this reviewed PR: k8snetworkplumbingwg/sriov-network-operator#325

@zshi-redhat

@vrindle vrindle force-pushed the generate_random_mac_addresses branch from a2c0874 to 0be1620 Compare June 23, 2022 10:44
…ess is zero.

This is to set VF effective MAC addresses when the VF effective MAC address is all zero for some vendor NICs.
@vrindle vrindle force-pushed the generate_random_mac_addresses branch from 0be1620 to 8bf3b9b Compare June 23, 2022 11:23
@SchSeba
Copy link
Contributor

SchSeba commented Jun 23, 2022

The PR on u/s was reverted I will like to not have d/s only changes..

@SchSeba
Copy link
Contributor

SchSeba commented Jun 27, 2022

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 27, 2022
@SchSeba
Copy link
Contributor

SchSeba commented Aug 11, 2022

closing this as we have a new PR
k8snetworkplumbingwg/sriov-network-operator#328

/close

@openshift-ci openshift-ci bot closed this Aug 11, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 11, 2022

@SchSeba: Closed this PR.

In response to this:

closing this as we have a new PR
k8snetworkplumbingwg/sriov-network-operator#328

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

SchSeba added a commit to SchSeba/sriov-network-operator that referenced this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants