Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - openstack: try to fetch Metadata service first #623

Closed
wants to merge 1 commit into from

Conversation

EmilienM
Copy link
Member

@EmilienM EmilienM commented Feb 8, 2022

In most cases, OpenStack metadata service is available in the cloud,
which removes the requirement of config-drive.

This patch will change the logic to try reading Metadata and Network data by
safely fetching the URL first and if it's not available, then it'll try
to read from the file provided by config-drive.

Note: it's adding a new dependency on hashicorp/go-retryablehttp which
is a library which provides a HTTP client interface with automatic retries
and exponential backoff.

@EmilienM EmilienM changed the title Automate network-resources-injector-secret deployment WIP - Automate network-resources-injector-secret deployment Feb 8, 2022
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 8, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 8, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: EmilienM
To complete the pull request process, please assign fepan after the PR has been reviewed.
You can assign the PR to them by writing /assign @fepan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested review from bn222 and s1061123 February 8, 2022 14:37
In most cases, OpenStack metadata service is available in the cloud,
which removes the requirement of config-drive.

This patch will change the logic to try reading Metadata and Network data by
safely fetching the URL first and if it's not available, then it'll try
to read from the file provided by config-drive.

Note: it's adding a new dependency on hashicorp/go-retryablehttp which
is a library which provides a HTTP client interface with automatic retries
and exponential backoff.
@EmilienM EmilienM changed the title WIP - Automate network-resources-injector-secret deployment WIP - openstack: try to fetch Metadata service first Feb 8, 2022
@EmilienM EmilienM closed this Feb 8, 2022
@EmilienM EmilienM deleted the metadata branch February 8, 2022 15:03
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 8, 2022

@EmilienM: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

zeeke added a commit to zeeke/sriov-network-operator that referenced this pull request Feb 8, 2024
Set OwnerReference to sriov-device-plugin configmap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant