Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG 2013199: Update operator bundle #606

Merged
merged 1 commit into from
Dec 21, 2021
Merged

BUG 2013199: Update operator bundle #606

merged 1 commit into from
Dec 21, 2021

Conversation

pliurh
Copy link
Contributor

@pliurh pliurh commented Dec 21, 2021

No description provided.

@pliurh pliurh requested a review from zshi-redhat December 21, 2021 07:03
@openshift-ci openshift-ci bot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Dec 21, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 21, 2021

@pliurh: This pull request references Bugzilla bug 2013199, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

BUG 2013199: Update operator bundle

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Dec 21, 2021
@openshift-ci openshift-ci bot requested review from Billy99 and s1061123 December 21, 2021 07:03
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 21, 2021
@pliurh
Copy link
Contributor Author

pliurh commented Dec 21, 2021

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Dec 21, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 21, 2021

@pliurh: This pull request references Bugzilla bug 2013199, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @zhaozhanqi

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from zhaozhanqi December 21, 2021 07:04
zshi-redhat
zshi-redhat reviewed Dec 21, 2021
View reviewed changes
manifests/4.10/supported-nic-ids_v1_configmap.yaml Outdated
@@ -22,8 +22,6 @@ data:
Nvidia_mlx5_ConnectX-5_Ex: 15b3 1019 101a
Nvidia_mlx5_ConnectX-6: 15b3 101b 101c
Nvidia_mlx5_ConnectX-6_Dx: 15b3 101d 101e
Nvidia_mlx5_ConnectX-6_Lx: 15b3 101f 101e
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why removing these two?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was synced from upstream. I think we shall keep it unchanged.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@zshi-redhat
Copy link
Contributor

we would also need this change in file deployment/sriov-network-operator/crds/sriovnetwork.openshift.io_sriovnetworknodestates.yaml?

@pliurh
Copy link
Contributor Author

pliurh commented Dec 21, 2021

we would also need this change in file deployment/sriov-network-operator/crds/sriovnetwork.openshift.io_sriovnetworknodestates.yaml?

Yes, but not in this PR. That file is only used by the upstream installation.

@pliurh
Copy link
Contributor Author

pliurh commented Dec 21, 2021

/test operator-e2e

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 21, 2021

@pliurh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zshi-redhat
Copy link
Contributor

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 21, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pliurh, zshi-redhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 21, 2021
@zshi-redhat
Copy link
Contributor

we would also need this change in file deployment/sriov-network-operator/crds/sriovnetwork.openshift.io_sriovnetworknodestates.yaml?

Yes, but not in this PR. That file is only used by the upstream installation.

Do we already have an upstream PR for this change?

@openshift-merge-robot openshift-merge-robot merged commit 57f053d into openshift:master Dec 21, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 21, 2021

@pliurh: All pull requests linked via external trackers have merged:

Bugzilla bug 2013199 has been moved to the MODIFIED state.

In response to this:

BUG 2013199: Update operator bundle

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

zeeke added a commit to zeeke/sriov-network-operator that referenced this pull request Feb 1, 2024
@zeeke
Merge pull request openshift#606 from adrianchiris/additional-control…
0eb0a14 
…ler-fixes

Cleanup Created object in controller tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zshi-redhat zshi-redhat zshi-redhat left review comments

@Billy99 Billy99 Awaiting requested review from Billy99

@s1061123 s1061123 Awaiting requested review from s1061123

@zhaozhanqi zhaozhanqi Awaiting requested review from zhaozhanqi

Assignees

@zshi-redhat zshi-redhat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pliurh @zshi-redhat @openshift-merge-robot