Bug 1993007: Use GlobalMgr for SriovNetwork controllers #554
Conversation
Using 2 managers for the same controllers causes inconsistency in objects reconcilation. For example we saw a problem with some SriovNetwork update events not reaching the controller (Reconcile was not triggered). Using the same Mgr as the specified client for the controller solves these kind of problems. Signed-off-by: Ori Braunshtein <[email protected]>
|
@oribon: This pull request references Bugzilla bug 1993007, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
bugzilla/severity-high
|
/bugzilla refresh |
|
@oribon: This pull request references Bugzilla bug 1993007, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
bugzilla/valid-bug
|
/lgtm |
|
/approve |
1 similar comment
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oribon, SchSeba, zshi-redhat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@oribon: All pull requests linked via external trackers have merged: Bugzilla bug 1993007 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Using 2 managers for the same controllers causes inconsistency in
objects reconcilation. For example we saw a problem with some SriovNetwork
update events not reaching the controller (Reconcile was not triggered).
Using the same Mgr as the specified client for the controller solves these kind of problems.
Cherry-pick from k8snetworkplumbingwg/sriov-network-operator#175
Signed-off-by: Ori Braunshtein [email protected]