Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix daemon pod log #533

Closed

Conversation

sabinaaledort
Copy link
Contributor

Some spaces were missing and the namespace should be before the pod name.

@openshift-ci openshift-ci bot requested review from s1061123 and zshi-redhat June 30, 2021 13:25
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 30, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sabinaaledort
To complete the pull request process, please assign squeed after the PR has been reviewed.
You can assign the PR to them by writing /assign @squeed in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@@ -168,7 +168,7 @@ func New(
verbStr = "Evicted"
}
glog.Info(fmt.Sprintf("%s pod from Node", verbStr),
"pod", fmt.Sprintf("%s/%s", pod.Name, pod.Namespace))
" pod ", fmt.Sprintf("%s/%s", pod.Namespace, pod.Name))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe even remove the pod here?

also mabe have one fmt.Sprintf

@SchSeba
Copy link
Contributor

SchSeba commented Jun 30, 2021

Some spaces were missing and the namespace should be before the pod name.
@sabinaaledort sabinaaledort force-pushed the fix_daemmon_pod_log branch from 34b5735 to 79e65c3 Compare July 1, 2021 11:14
@sabinaaledort
Copy link
Contributor Author

This change was done in the u/s repo and will be copied in the next sync from upstream.
k8snetworkplumbingwg/sriov-network-operator#154

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants