Bug 1914852: Fix Main PF panic #455
Conversation
This commit fix a panic when the test is not able to find a main PF in discovery mode
```
•! Panic [15.745 seconds]
[sriov] operator
/remote-source/app/vendor/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/tests/sriov_operator.go:64
Custom SriovNetworkNodePolicy
/remote-source/app/vendor/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/tests/sriov_operator.go:827
Configuration
/remote-source/app/vendor/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/tests/sriov_operator.go:835
Main PF
/remote-source/app/vendor/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/tests/sriov_operator.go:1044
should work when vfs are used by pods [It]
/remote-source/app/vendor/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/tests/sriov_operator.go:1045
Test Panicked
runtime error: invalid memory address or nil pointer dereference
/opt/rh/go-toolset-1.13/root/usr/lib/go-toolset-1.13-golang/src/runtime/panic.go:199
Full Stack Trace
github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/tests.findSuitableResourceForMain(0x0, 0xc000a07380, 0x2bb1f40, 0x0, 0x0)
/remote-source/app/vendor/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/tests/sriov_operator.go:1548 +0xdc
github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/tests.discoverResourceForMainSriov(0xc001551680, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0)
/remote-source/app/vendor/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/tests/sriov_operator.go:1537 +0x421
github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/tests.glob..func1.5.2.2.1()
/remote-source/app/vendor/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/tests/sriov_operator.go:1059 +0x61
github.com/openshift-kni/cnf-features-deploy/functests_test.TestTest(0xc0004d4d00)
/remote-source/app/functests/test_suite_test.go:82 +0xf3
testing.tRunner(0xc0004d4d00, 0x1b5b280)
/opt/rh/go-toolset-1.13/root/usr/lib/go-toolset-1.13-golang/src/testing/testing.go:909 +0xc9
created by testing.(*T).Run
/opt/rh/go-toolset-1.13/root/usr/lib/go-toolset-1.13-golang/src/testing/testing.go:960 +0x350
```
Signed-off-by: Sebastian Sch <[email protected]>
openshift-ci-robot
added
the
approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fedepaol, SchSeba The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
bugzilla/severity-unspecified
|
@SchSeba: This pull request references Bugzilla bug 1914852, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@SchSeba: All pull requests linked via external trackers have merged: Bugzilla bug 1914852 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fix race condition in leader election for OCP
This commit fix a panic when the test is not able to find a main PF in discovery mode
Signed-off-by: Sebastian Sch [email protected]