Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-41352: Merge https://github.com/k8snetworkplumbingwg/sriov-network-operator:master into master #1005

Merged
merged 7 commits into from
Sep 19, 2024
Merged

OCPBUGS-41352: Merge https://github.com/k8snetworkplumbingwg/sriov-network-operator:master into master #1005

merged 7 commits into from
Sep 19, 2024

Conversation

SchSeba
Copy link
Contributor

@SchSeba SchSeba commented Sep 17, 2024

No description provided.

zeeke added 4 commits August 29, 2024 07:34
@zeeke
eSwitch: e2e test for Switchdev mode
1beef18 
Add a basic test to loop over all available
devices and test if setting `eSwitchMode: switchdev` works.

Signed-off-by: Andrea Panattoni <[email protected]>
@zeeke
eSwitch: switchdev and VF creation order
976e657 
Ice driver supports creating VFs after the eSwitcMode is
set to switchdev. This is different than the preferred way
for `mlx5` driver.

Add specific functions to configure eSwitchMode and SriovNumVFs
for each driver.

Signed-off-by: Andrea Panattoni <[email protected]>
@zeeke
Preserve user defined annotations on SriovNetworks
4d9ec9c 
If an SriovNetwork is created with some annotations, the operator
deletes them during the creation of  the related NetworkAttachmentDefinition.

Make the reconcilers append the `last-network-namespace` annotation
without deleting existing ones.

The same concept applies for `SriovIbNetworks` and `OVSNetworks`

Signed-off-by: Andrea Panattoni <[email protected]>
@zeeke
Merge pull request openshift#757 from zeeke/intel-switchdev
e812d35 
Intel switchdev
@openshift-ci openshift-ci bot requested review from fepan and pliurh September 17, 2024 23:51
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2024
@zeeke
Copy link
Contributor

zeeke commented Sep 18, 2024

/test ci/prow/operator-e2e

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 18, 2024

@zeeke: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test api
  • /test ci-index-operator-bundle
  • /test controllers
  • /test gofmt
  • /test images
  • /test operator-e2e
  • /test pkg

The following commands are available to trigger optional jobs:

  • /test e2e-openstack-nfv
  • /test e2e-openstack-nfv-config-drive
  • /test e2e-telco5g-sriov
  • /test security

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-sriov-network-operator-master-api
  • pull-ci-openshift-sriov-network-operator-master-ci-index-operator-bundle
  • pull-ci-openshift-sriov-network-operator-master-controllers
  • pull-ci-openshift-sriov-network-operator-master-e2e-openstack-nfv
  • pull-ci-openshift-sriov-network-operator-master-e2e-openstack-nfv-config-drive
  • pull-ci-openshift-sriov-network-operator-master-gofmt
  • pull-ci-openshift-sriov-network-operator-master-images
  • pull-ci-openshift-sriov-network-operator-master-operator-e2e
  • pull-ci-openshift-sriov-network-operator-master-pkg
  • pull-ci-openshift-sriov-network-operator-master-security

In response to this:

/test ci/prow/operator-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@zeeke
Copy link
Contributor

zeeke commented Sep 18, 2024

/test operator-e2e

@zeeke
Copy link
Contributor

zeeke commented Sep 18, 2024

/test e2e-telco5g-sriov

@zeeke
Copy link
Contributor

zeeke commented Sep 19, 2024

/retest
/test e2e-telco5g-sriov

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 19, 2024

@SchSeba: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@zeeke
Copy link
Contributor

zeeke commented Sep 19, 2024

/lgtm

New switchdev test passes:

�[0m[sriov] Switchdev �[0m�[1mcreate switchdev policies on supported devices�[0m
�[38;5;243m/go/src/github.com/openshift/sriov-network-operator/test/conformance/tests/test_switchdev.go:37�[0m
Waiting for the sriov state to stable
Sriov state is stable
  �[1mSTEP:�[0m Testing on node cnfdr16.telco5g.eng.rdu2.redhat.com, 2 devices found �[38;5;243m@ 09/19/24 10:21:07.672�[0m
  �[1mSTEP:�[0m Testing device ens1f0 (8086:1592) on node cnfdr16.telco5g.eng.rdu2.redhat.com �[38;5;243m@ 09/19/24 10:21:07.672�[0m
Waiting for the sriov state to stable
Sriov state is stable
  �[1mSTEP:�[0m Testing device ens3f0np0 (15b3:101d) on node cnfdr16.telco5g.eng.rdu2.redhat.com �[38;5;243m@ 09/19/24 10:21:17.767�[0m
Waiting for the sriov state to stable
Sriov state is stable
�[38;5;10m• [522.249 seconds]�[0m

https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift_sriov-network-operator/1005/pull-ci-openshift-sriov-network-operator-master-e2e-telco5g-sriov/1836674287168131072/artifacts/e2e-telco5g-sriov/e2e-conformance/build-log.txt

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SchSeba, zeeke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 0e981dd into openshift:master Sep 19, 2024
12 checks passed
@zeeke
Copy link
Contributor

zeeke commented Sep 19, 2024

/retitle OCPBUGS-41352: Merge https://github.com/k8snetworkplumbingwg/sriov-network-operator:master into master

@openshift-ci openshift-ci bot changed the title Merge https://github.com/k8snetworkplumbingwg/sriov-network-operator:master into master OCPBUGS-41352: Merge https://github.com/k8snetworkplumbingwg/sriov-network-operator:master into master Sep 19, 2024
@openshift-ci-robot
Copy link
Contributor

@SchSeba: Jira Issue OCPBUGS-41352: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-41352 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: sriov-network-config-daemon
This PR has been included in build sriov-network-config-daemon-container-v4.18.0-202409191611.p0.g0e981dd.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: sriov-network-webhook
This PR has been included in build sriov-network-webhook-container-v4.18.0-202409191611.p0.g0e981dd.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: sriov-network-operator
This PR has been included in build sriov-network-operator-container-v4.18.0-202409200008.p0.g0e981dd.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fepan fepan Awaiting requested review from fepan

@pliurh pliurh Awaiting requested review from pliurh

Assignees

@zeeke zeeke

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SchSeba @zeeke @openshift-ci-robot @openshift-bot