OCPBUGS-37668: [release-4.17]: Fix operator quick restart for SNO #1001
Conversation
When webooks are disabled, shutdown procedure produces the following
panic error:
```
2024-08-13T12:45:04.971685297Z INFO shutdown utils/shutdown.go:22 Done clearing finalizers on exit
2024-08-13T12:45:04.971713179Z INFO shutdown utils/shutdown.go:23 Seting webhook failure policies to Ignore on exit
2024-08-13T12:45:04.978386488Z ERROR shutdown utils/shutdown.go:64 Error getting webhook {"error": "validatingwebhookconfigurations.admissionregistration.k8s.io \"sriov-operator-webhook-config\" not found"}
panic: runtime error: index out of range [0] with length 0
goroutine 1 [running]:
github.com/k8snetworkplumbingwg/sriov-network-operator/pkg/utils.updateValidatingWebhook(0x37d7788?)
/go/src/github.com/k8snetworkplumbingwg/sriov-network-operator/pkg/utils/shutdown.go:75 +0x198
github.com/k8snetworkplumbingwg/sriov-network-operator/pkg/utils.updateWebhooks()
/go/src/github.com/k8snetworkplumbingwg/sriov-network-operator/pkg/utils/shutdown.go:64 +0xa5
github.com/k8snetworkplumbingwg/sriov-network-operator/pkg/utils.Shutdown()
/go/src/github.com/k8snetworkplumbingwg/sriov-network-operator/pkg/utils/shutdown.go:23 +0x14
main.main()
/go/src/github.com/k8snetworkplumbingwg/sriov-network-operator/main.go:296 +0x1e6a
```
Fix the panic error and add an end2end test case to cover it.
Signed-off-by: Andrea Panattoni <[email protected]>
openshift-ci-robot
added
jira/severity-important
|
@zeeke: This pull request references Jira Issue OCPBUGS-37668, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/invalid-bug
openshift-ci
bot
added
the
approved
|
/retest |
|
@zeeke: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@zeeke: This pull request references Jira Issue OCPBUGS-37668, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test e2e-telco5g-sriov |
|
🟢 newly added test case passed on ci/prow/e2e-telco5g-sriov: @SchSeba @evgenLevin can you please take a look at this backport? |
|
@SchSeba, @wizhaoredhat can you take a look at this backport? @evgenLevin, @ajaggapa, I need qe approval, too, when you have time ( |
|
/cherry-pick-approved |
did you mean |
|
/label cherry-pick-approved |
|
/lgtm |
openshift-ci
bot
added
the
backport-risk-assessed
openshift-ci
bot
assigned ajaggapa, anuragthehatter, asood-rh, evgenLevin, huiran0826, jechen0648 and mffiedler
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SchSeba, zeeke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/label cherry-pick-approved |
openshift-ci
bot
added
the
cherry-pick-approved
|
/override ci/prow/e2e-openstack-nfv-hwoffload job |
|
@zeeke: Overrode contexts on behalf of zeeke: ci/prow/e2e-openstack-nfv-hwoffload In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-merge-bot
bot
merged commit 40fc75e
into
openshift:release-4.17
|
@zeeke: Jira Issue OCPBUGS-37668: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-37668 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira backport release-4.16,release-4.15,release-4.14 |
|
@zeeke: Missing required branches for backport chain:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cherrypick release-4.16 |
|
@zeeke: new pull request created: #1011 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[ART PR BUILD NOTIFIER] Distgit: sriov-network-operator |
|
[ART PR BUILD NOTIFIER] Distgit: sriov-network-config-daemon |
|
[ART PR BUILD NOTIFIER] Distgit: sriov-network-webhook |
4.17 Backport of: