[RFE-5098] Support for customizing HAProxy error code response page for http error code 504

[natlibfi-jonollil]

I'm not sure if this is enough to make this work. Or should this be against master or next release version?

We have noticed problems regarding error response descriptions with HA-proxy. Problems have been encountered during timeouts and whitelisting as in these cases request produces blank response and this makes debugging work difficult. After finding out the reasons for the problems, we propose adding status codes 504 and 403 to the error responses to help identifying problems with timeouts and access rights in the future.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign miciah for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

Hi @natlibfi-jonollil. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[candita]

@natlibfi-jonollil there's a little more needed than this. #274 has an example, but you'd also need to make sure the two new environment variables are implemented in the ingress controller code. openshift/cluster-ingress-operator#588 has an example as well as unit or end to end testing that would need to be added.

[candita]

Also even though the lines are not currently ordered, we would ask you to order these lines by error code number: 403 404 503 504. Note that these capitalized env variables have exist so that people can customize their error pages if they don't want the default.

[candita]

/assign

[candita]

@natlibfi-jonollil please let us know if you intend to pursue this feature.
/label ok-to-test

[openshift-ci]

@candita: The label(s) /label ok-to-test cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

@natlibfi-jonollil please let us know if you intend to pursue this feature.
/label ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[candita]

/ok-to-test

[openshift-ci]

@natlibfi-jonollil: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	2d7eb5e	link	false	/test okd-scos-e2e-aws-ovn
ci/prow/e2e-upgrade	2d7eb5e	link	true	/test e2e-upgrade
ci/prow/e2e-agnostic	2d7eb5e	link	true	/test e2e-agnostic
ci/prow/e2e-metal-ipi-ovn-ipv6	2d7eb5e	link	false	/test e2e-metal-ipi-ovn-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.