Fixes #419: Allow configuration of haproxy option persist

[thomaswoeckinger]

No description provided.

[openshift-ci]

Hi @thomaswoeckinger. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[thomaswoeckinger]

/assign @candita

[thomaswoeckinger]

/assign @frobware

[frobware]

As this would be new functionality please can you file an RFE under https://issues.redhat.com/projects/RFE/issues with the "Network Edge" component. PM and engineering meet regularly to discuss all RFEs.

[frobware]

/unassign

[thomaswoeckinger]

As this would be new functionality please can you file an RFE under https://issues.redhat.com/projects/RFE/issues with the "Network Edge" component. PM and engineering meet regularly to discuss all RFEs.

@frobware
After login, when clicking the create button it is not possible to create an issue for the project Openshift Request for Enhancement. There is also no Project Network Edge or similar available.

Maybe i do not have permissions for that projects?

[Miciah]

/assign

[thomaswoeckinger]

@Miciah Can you change the permissions to Openshift Request for Enhancement so that i can create an RFE?

[thomaswoeckinger]

/assign @Miciah

[candita]

@thomaswoeckinger Thank you for the PR. As @frobware mentioned, this looks like a new feature. We have a new RFE process, so will look into why can't use it, but in the meantime:

We need a better description in this PR, and annotation unit testing in TestConfigTemplate, see https://github.com/openshift/router/blob/master/pkg/router/router_test.go#L181

Would you be willing to make a PR to add documentation for the new annotation? Route annotations are documented here: https://github.com/openshift/openshift-docs/blob/main/modules/nw-route-specific-annotations.adoc

[thomaswoeckinger]

@thomaswoeckinger Thank you for the PR. As @frobware mentioned, this looks like a new feature. We have a new RFE process, so will look into why can't use it, but in the meantime:

We need a better description in this PR, and annotation unit testing in TestConfigTemplate, see https://github.com/openshift/router/blob/master/pkg/router/router_test.go#L181

I will add one

Would you be willing to make a PR to add documentation for the new annotation? Route annotations are documented here: https://github.com/openshift/openshift-docs/blob/main/modules/nw-route-specific-annotations.adoc

I will add some documentation to.

[thomaswoeckinger]

@Miciah , @frobware , @candita due to testing i found out that the router will remove a server entry from the backend as soon as the EndpointSlice is marked as ready state 'false' even if serving state is 'true'.
Instead a set server <backend>/<server> state drainshould be issued on the router.
Can you tell me an code entry point where it is possible to issue such a command?

[candita]

@Miciah , @frobware , @candita due to testing i found out that the router will remove a server entry from the backend as soon as the EndpointSlice is marked as ready state 'false' even if serving state is 'true'. Instead a set server <backend>/<server> state drainshould be issued on the router. Can you tell me an code entry point where it is possible to issue such a command?

@thomaswoeckinger we will get in touch regarding the next steps on this one. It's possible that this will require a RFE and enhancement document.

[thomaswoeckinger]

Added test case for the new option, as the used parser does not support retrieval of option attribute at the moment, i had to check it by simple old string parsing

[thomaswoeckinger]

@Miciah @candita @frobware Added a pull request for the documentation openshift/openshift-docs#52923

[Miciah]

/ok-to-test

[thomaswoeckinger]

@Miciah The two failing test jobs are not related to the changes as far as i see

[thomaswoeckinger]

/retest-required

[thomaswoeckinger]

/retest

[thomaswoeckinger]

@Miciah @candita @frobware test are successful now

[thomaswoeckinger]

@Miciah @candita @frobware anything new?

[thomaswoeckinger]

@Miciah @candita @frobware ping

[thomaswoeckinger]

As this would be new functionality please can you file an RFE under https://issues.redhat.com/projects/RFE/issues with the "Network Edge" component. PM and engineering meet regularly to discuss all RFEs.

@frobware Can you tell me the project to use.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from miciah. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@thomaswoeckinger: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-serial	90418bd	link	true	/test e2e-aws-serial
ci/prow/e2e-upgrade	90418bd	link	true	/test e2e-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[thomaswoeckinger]

As this would be new functionality please can you file an RFE under https://issues.redhat.com/projects/RFE/issues with the "Network Edge" component. PM and engineering meet regularly to discuss all RFEs.

I still can not create an issue because when i click 'create' there is no project RFE or 'Openshift Request for Enhancement' available i use [email protected] as login

[thomaswoeckinger]

/remove-lifecycle stale

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[openshift-bot]

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

[openshift-bot]

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

[openshift-ci]

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.