Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM-11556 | fix: remove multiple ca tests from getClusterRegistryConfig #2520

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

chenz4027
Copy link
Contributor

@chenz4027 chenz4027 commented Oct 1, 2024

@openshift-ci openshift-ci bot requested review from hunterkepley and pvasant October 1, 2024 13:43
Copy link
Contributor

openshift-ci bot commented Oct 1, 2024

@chenz4027: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.85%. Comparing base (a3c9f7a) to head (42cc529).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2520   +/-   ##
=======================================
  Coverage   29.85%   29.85%           
=======================================
  Files         165      165           
  Lines       22844    22844           
=======================================
  Hits         6821     6821           
  Misses      15462    15462           
  Partials      561      561           
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@den-rgb
Copy link
Contributor

den-rgb commented Oct 1, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2024
Copy link
Contributor

openshift-ci bot commented Oct 1, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: andreadecorte, chenz4027, den-rgb
Once this PR has been reviewed and has the lgtm label, please assign pvasant for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gdbranco gdbranco merged commit 3300a71 into openshift:master Oct 1, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants