Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM-8435 | chore: bump gci version to correctly handle newer golang versions #2126

Merged
merged 1 commit into from
May 31, 2024

Conversation

andreadecorte
Copy link
Contributor

The changes are notably related to the ordering of the slices packages which is introduced in Go 1.21

…ersions

The changes are notably related to the ordering of the `slices` packages
which is introduced in Go 1.21
Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.65%. Comparing base (2cc09c9) to head (b9d20a9).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2126      +/-   ##
==========================================
- Coverage   26.65%   26.65%   -0.01%     
==========================================
  Files         152      152              
  Lines       21407    21402       -5     
==========================================
- Hits         5707     5705       -2     
+ Misses      15275    15273       -2     
+ Partials      425      424       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

openshift-ci bot commented May 31, 2024

@andreadecorte: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@davidleerh
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 31, 2024
Copy link
Contributor

openshift-ci bot commented May 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreadecorte, davidleerh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 31, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit f8cd646 into openshift:master May 31, 2024
11 checks passed
@andreadecorte andreadecorte deleted the OCM-8435 branch June 3, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants