OCM-6391 | fix: Add region deprecation disablement to sub-commands

[hunterkepley]

OCM-6391

is a ticket where we temporarily deprecate the region flag before removing it from commands which do not use it. This is a bug fix for the create cluster command, which housed 4 commands that have this deprecation.

[codecov]

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 24.02%. Comparing base (7cfde09) to head (cb1b1f6).
Report is 8 commits behind head on master.

Files	Patch %	Lines
cmd/create/cluster/cmd.go	0.00%	2 Missing ⚠️
cmd/upgrade/cluster/cmd.go	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1992      +/-   ##
==========================================
+ Coverage   23.99%   24.02%   +0.03%     
==========================================
  Files         138      138              
  Lines       21428    21425       -3     
==========================================
+ Hits         5141     5147       +6     
+ Misses      15885    15876       -9     
  Partials      402      402              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[openshift-ci]

@hunterkepley: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[gdbranco]

/approve
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gdbranco, hunterkepley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [gdbranco]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[davidleerh]

/cherry-pick release_1.2.39

[openshift-cherrypick-robot]

@davidleerh: #1992 failed to apply on top of branch "release_1.2.39":

Applying: OCM-6391 | fix: Add region deprecation disablement to sub-commands
Using index info to reconstruct a base tree...
M	cmd/create/cluster/cmd.go
Falling back to patching base and 3-way merge...
Auto-merging cmd/create/cluster/cmd.go
CONFLICT (content): Merge conflict in cmd/create/cluster/cmd.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OCM-6391 | fix: Add region deprecation disablement to sub-commands
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release_1.2.39

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[davidleerh]

/cherry-pick release_1.2.39

[openshift-cherrypick-robot]

@davidleerh: new pull request created: #2010

In response to this:

/cherry-pick release_1.2.39

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.