Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM-7729 | fix: check policy attached in detach manual mode #1991

Merged
merged 1 commit into from
May 2, 2024

Conversation

marcolan018
Copy link
Contributor

@marcolan018 marcolan018 commented May 1, 2024

@openshift-ci openshift-ci bot requested review from ciaranRoche and thomasmckay May 1, 2024 21:50
Copy link

codecov bot commented May 1, 2024

Codecov Report

Attention: Patch coverage is 37.50000% with 30 lines in your changes are missing coverage. Please review.

Project coverage is 23.72%. Comparing base (cd2d1ab) to head (e4b2263).
Report is 4 commits behind head on master.

Files Patch % Lines
pkg/aws/policies.go 0.00% 11 Missing ⚠️
pkg/aws/mock_client.go 0.00% 9 Missing ⚠️
cmd/detach/policy/cmd.go 0.00% 8 Missing ⚠️
pkg/policy/policy_service.go 90.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1991      +/-   ##
==========================================
+ Coverage   23.56%   23.72%   +0.16%     
==========================================
  Files         138      138              
  Lines       21334    21846     +512     
==========================================
+ Hits         5028     5184     +156     
- Misses      15931    16256     +325     
- Partials      375      406      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ciaranRoche ciaranRoche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 2, 2024
Copy link
Contributor

openshift-ci bot commented May 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ciaranRoche, marcolan018

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 2, 2024
Copy link
Contributor

openshift-ci bot commented May 2, 2024

@marcolan018: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 26bdf17 into openshift:master May 2, 2024
10 checks passed
@marcolan018 marcolan018 deleted the ocm-7729 branch May 2, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants