OCM-7593 | test: automate id:OCP-36128 Updated a new checkpoint #1959
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1959 +/- ##
==========================================
+ Coverage 22.91% 23.22% +0.30%
==========================================
Files 134 136 +2
Lines 20979 21160 +181
==========================================
+ Hits 4807 4914 +107
- Misses 15817 15879 +62
- Partials 355 367 +12 ☔ View full report in Codecov by Sentry. |
tests/e2e/test_rosacli_user.go
Outdated
| _, output, err := userService.ListUsers(clusterID) | ||
| Expect(err).ToNot(HaveOccurred()) | ||
| textData := rosaClient.Parser.TextData.Input(output).Parse().Tip() | ||
| Expect(textData).To(ContainSubstring(fmt.Sprintf("INFO: There are no users configured for cluster '%s'", clusterID))) |
There was a problem hiding this comment.
ContainSubstring supports Sprintf, don't need to sprintf again
| Expect(textData).To(ContainSubstring(fmt.Sprintf("INFO: There are no users configured for cluster '%s'", clusterID))) | |
| Expect(textData).To(ContainSubstring("INFO: There are no users configured for cluster '%s'", clusterID)) |
There was a problem hiding this comment.
@xueli181114 Yes updated, Thanks
|
/approve |
openshift-ci
bot
added
the
approved
|
/retest |
|
@aaraj7: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aaraj7, xueli181114, yingzhanredhat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
output log:- https://privatebin.corp.redhat.com/?383891ea8e850470#3CYKehGgb3Q93EyCm28WkMgxvwUuBZhdpNcUW7YVhvNE