Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCM-1308 | fix: filter empty subnet id #1950

Merged
merged 1 commit into from
Apr 24, 2024
Merged

OCM-1308 | fix: filter empty subnet id #1950

merged 1 commit into from
Apr 24, 2024

Conversation

chenz4027
Copy link
Contributor

@openshift-ci openshift-ci bot requested review from oriAdler and pvasant April 19, 2024 17:44
@codecov Codecov
Copy link

codecov bot commented Apr 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 22.98%. Comparing base (86498a9) to head (23192dc).
Report is 18 commits behind head on master.

Files Patch % Lines
cmd/create/cluster/cmd.go 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1950      +/-   ##
==========================================
+ Coverage   22.43%   22.98%   +0.55%     
==========================================
  Files         129      134       +5     
  Lines       20550    21411     +861     
==========================================
+ Hits         4610     4921     +311     
- Misses      15592    16135     +543     
- Partials      348      355       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mikeshng
mikeshng reviewed Apr 19, 2024
View reviewed changes
cmd/create/cluster/cmd.go Outdated Show resolved Hide resolved
@chenz4027 chenz4027 force-pushed the OCM-1308 branch 2 times, most recently from 7766b92 to d376ff8 Compare April 19, 2024 19:34
mikeshng
mikeshng approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@mikeshng mikeshng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2024
ciaranRoche
ciaranRoche reviewed Apr 22, 2024
View reviewed changes
pkg/helper/helpers.go Outdated Show resolved Hide resolved
pkg/helper/helpers.go Outdated Show resolved Hide resolved
@chenz4027
OCM-1308 | fix: filter empty subnet id
23192dc 
Signed-off-by: Maggie Chen <[email protected]>

add test

Signed-off-by: Maggie Chen <[email protected]>

refactor

Signed-off-by: Maggie Chen <[email protected]>

fix comment

Signed-off-by: Maggie Chen <[email protected]>

fix comment

Signed-off-by: Maggie Chen <[email protected]>

rename

Signed-off-by: Maggie Chen <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2024
@chenz4027 chenz4027 requested a review from ciaranRoche April 22, 2024 14:33
ciaranRoche
ciaranRoche approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@ciaranRoche ciaranRoche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chenz4027, ciaranRoche, mikeshng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 24, 2024

@chenz4027: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 9dea294 into openshift:master Apr 24, 2024
10 checks passed
@chenz4027 chenz4027 deleted the OCM-1308 branch May 9, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeshng mikeshng mikeshng approved these changes

@ciaranRoche ciaranRoche ciaranRoche approved these changes

@oriAdler oriAdler Awaiting requested review from oriAdler

@pvasant pvasant Awaiting requested review from pvasant

Assignees

@ciaranRoche ciaranRoche

@mikeshng mikeshng

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chenz4027 @ciaranRoche @mikeshng