Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM-7253 | feat: Refactor describe machine pool cmd to use new default runner #1938

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

hunterkepley
Copy link
Contributor

@hunterkepley hunterkepley commented Apr 16, 2024

OCM-7253

Pt 2 to the RCI Milestone 2 for describe machine-pool

Refactors the command to use new default runner, and refactors tests

DoD:

Command uses new default runner
Command has at least 70% unit test coverage

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

Attention: Patch coverage is 88.33333% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 22.57%. Comparing base (2eaeea7) to head (e86d5a7).
Report is 38 commits behind head on master.

Files Patch % Lines
cmd/describe/machinepool/cmd.go 79.41% 3 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1938      +/-   ##
==========================================
+ Coverage   21.69%   22.57%   +0.88%     
==========================================
  Files         118      131      +13     
  Lines       19797    20861    +1064     
==========================================
+ Hits         4294     4710     +416     
- Misses      15181    15799     +618     
- Partials      322      352      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hunterkepley
Copy link
Contributor Author

DoD met

@hunterkepley hunterkepley force-pushed the ocm-7253 branch 5 times, most recently from 3c31cdd to 49fb868 Compare April 17, 2024 15:31
@hunterkepley
Copy link
Contributor Author

/retest

Copy link
Contributor

@robpblake robpblake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2024
Copy link
Contributor

openshift-ci bot commented Apr 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hunterkepley, robpblake

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2024
Copy link
Contributor

openshift-ci bot commented Apr 19, 2024

@hunterkepley: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 26d550d into openshift:master Apr 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants