-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCM-7253 | feat: Refactor describe machine pool cmd to use new default runner #1938
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1938 +/- ##
==========================================
+ Coverage 21.69% 22.57% +0.88%
==========================================
Files 118 131 +13
Lines 19797 20861 +1064
==========================================
+ Hits 4294 4710 +416
- Misses 15181 15799 +618
- Partials 322 352 +30 ☔ View full report in Codecov by Sentry. |
DoD met |
3c31cdd
to
49fb868
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hunterkepley, robpblake The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@hunterkepley: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
OCM-7253
Pt 2 to the RCI Milestone 2 for
describe machine-pool
Refactors the command to use new default runner, and refactors tests
DoD: