Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM-7451 | test: automate id:OCP-63179 create nodepool with tuning config will validate well #1928

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

aaraj7
Copy link
Contributor

@aaraj7 aaraj7 commented Apr 15, 2024

@openshift-ci openshift-ci bot requested review from radtriste and yasun1 April 15, 2024 11:10
@aaraj7
Copy link
Contributor Author

aaraj7 commented Apr 15, 2024

/retest

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.42%. Comparing base (b480a5d) to head (d88da4a).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1928      +/-   ##
==========================================
+ Coverage   21.71%   22.42%   +0.70%     
==========================================
  Files         118      126       +8     
  Lines       19809    20105     +296     
==========================================
+ Hits         4302     4508     +206     
- Misses      15186    15249      +63     
- Partials      321      348      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yingzhanredhat
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2024
tests/e2e/test_rosacli_node_pool.go Outdated Show resolved Hide resolved
tests/e2e/test_rosacli_node_pool.go Outdated Show resolved Hide resolved
@yasun1
Copy link
Contributor

yasun1 commented Apr 18, 2024

@aaraj7 Please use the pastebin https://privatebin.corp.redhat.com/ for your output. Don't show sensitive information(e.g. the billing account: 301721915996 ) out

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2024
@yingzhanredhat
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2024
@aaraj7 aaraj7 changed the title Added automation script for tc-id OCP_63179 OCM-7451 | test: automate id:OCP-63179 create nodepool with tuning config will validate well Apr 18, 2024
@yasun1
Copy link
Contributor

yasun1 commented Apr 18, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2024
Copy link
Contributor

openshift-ci bot commented Apr 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aaraj7, yasun1, yingzhanredhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 18, 2024
Copy link
Contributor

openshift-ci bot commented Apr 18, 2024

@aaraj7: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit b1c9d07 into openshift:master Apr 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants