-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCM-6309 | ci: Verify test case(s) 45161|35878|35896|49137|46187|38850|34102|66362|36128 #1925
Conversation
…0|34102|66362|36128 Fixed 45161
/assign @yasun1 @ciaranRoche @yuwang-RH @oriAdler |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1925 +/- ##
==========================================
+ Coverage 21.77% 22.20% +0.42%
==========================================
Files 118 120 +2
Lines 19786 19945 +159
==========================================
+ Hits 4308 4428 +120
- Misses 15152 15189 +37
- Partials 326 328 +2 ☔ View full report in Codecov by Sentry. |
regexp.MustCompile(`(--bind-password\s+)([^\n\t\\\s]+)([\n\\\s]*)`), | ||
regexp.MustCompile(`(--client-secret\s+)([^\n\t\\\s]+)([\n\\\s]*)`), | ||
regexp.MustCompile(`(--users\s+[a-zA-Z0-9-]+:)([^\s\n\\]+)([\s\S]+)`), | ||
regexp.MustCompile(`(--cluster-admin-password\s+)([^\n\t\\\s]+)([\n\\\s]*)`), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a reminder that we also need to mask the AWS billing account in the future.
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xueli181114, yasun1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@xueli181114: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Here is the log https://privatebin.corp.redhat.com/?5575217bfbaec3ee#7dSdFKmDgqGyYznqLkBNA5xq5rhcjcQ2VtDjeVaANq2e