Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM-7135 | fix: add validation for revoking breakglasscredential #1900

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

chenz4027
Copy link
Contributor

@openshift-ci openshift-ci bot requested review from pvasant and robpblake April 3, 2024 20:14
Copy link
Contributor

openshift-ci bot commented Apr 3, 2024

@chenz4027: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 21.12%. Comparing base (6f1f390) to head (678014e).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1900   +/-   ##
=======================================
  Coverage   21.12%   21.12%           
=======================================
  Files         118      118           
  Lines       19781    19781           
=======================================
  Hits         4178     4178           
  Misses      15289    15289           
  Partials      314      314           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andreadecorte
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2024
@gdbranco
Copy link
Contributor

gdbranco commented Apr 4, 2024

/approve

Copy link
Contributor

openshift-ci bot commented Apr 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreadecorte, chenz4027, gdbranco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 5935b9c into openshift:master Apr 4, 2024
9 checks passed
@chenz4027 chenz4027 deleted the OCM-7135 branch May 9, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants