Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM-6955 | fix: provide better message for external auth creation #1896

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

chenz4027
Copy link
Contributor

@openshift-ci openshift-ci bot requested review from marcolan018 and willkutler April 2, 2024 14:56
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 21.88%. Comparing base (c9f520d) to head (0fdb9f0).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1896      +/-   ##
==========================================
+ Coverage   21.82%   21.88%   +0.05%     
==========================================
  Files         117      117              
  Lines       18929    18935       +6     
==========================================
+ Hits         4132     4144      +12     
+ Misses      14487    14477      -10     
- Partials      310      314       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oriAdler
Copy link
Contributor

oriAdler commented Apr 3, 2024

LGTM

Signed-off-by: Maggie Chen <[email protected]>

more detail

Signed-off-by: Maggie Chen <[email protected]>

change to clusterkey

Signed-off-by: Maggie Chen <[email protected]>
Copy link
Contributor

openshift-ci bot commented Apr 3, 2024

@chenz4027: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@chenz4027 chenz4027 requested a review from robpblake April 3, 2024 13:58
@robpblake
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2024
Copy link
Contributor

openshift-ci bot commented Apr 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chenz4027, robpblake

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 3, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit f6b0b9d into openshift:master Apr 3, 2024
9 checks passed
@chenz4027 chenz4027 deleted the OCM-6955 branch May 9, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants