-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCM-6955 | fix: provide better message for external auth creation #1896
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1896 +/- ##
==========================================
+ Coverage 21.82% 21.88% +0.05%
==========================================
Files 117 117
Lines 18929 18935 +6
==========================================
+ Hits 4132 4144 +12
+ Misses 14487 14477 -10
- Partials 310 314 +4 ☔ View full report in Codecov by Sentry. |
LGTM |
Signed-off-by: Maggie Chen <[email protected]> more detail Signed-off-by: Maggie Chen <[email protected]> change to clusterkey Signed-off-by: Maggie Chen <[email protected]>
@chenz4027: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chenz4027, robpblake The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
https://issues.redhat.com/browse/OCM-6955