OCM-7110 | fix: GitHub IDP validation

[mnecas]

Switch from URI validation to the DNS1123 validation. The openshift does not accept the URI format of domains. So when user specifies some address with prefix https:// it will fail.

[openshift-ci]

Hi @mnecas. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[robpblake]

/ok-to-test

[robpblake]

@mnecas You need to update your commit message to: OCM-7110 | fix: GitHub IDP validation

cheers,
Rob

[gdbranco]

Will also require changes to the interactive validation

rosa/cmd/create/idp/github.go

Line 203 in 8396138

interactive.IsURL,

[gdbranco]

/test test

[openshift-ci]

@mnecas: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 21.88%. Comparing base (c9f520d) to head (fca6f45).
Report is 2 commits behind head on master.

Files	Patch %	Lines
pkg/interactive/validation.go	0.00%	6 Missing ⚠️
cmd/create/idp/github.go	0.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1895      +/-   ##
==========================================
+ Coverage   21.82%   21.88%   +0.05%     
==========================================
  Files         117      117              
  Lines       18929    18935       +6     
==========================================
+ Hits         4132     4144      +12     
+ Misses      14487    14477      -10     
- Partials      310      314       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[gdbranco]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gdbranco, mnecas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [gdbranco]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment