-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCM-6883 | fix: rosa describe admin can list the admin with custom name #1873
Conversation
Signed-off-by: marcolan018 <[email protected]>
/retest |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1873 +/- ##
==========================================
+ Coverage 21.47% 21.49% +0.01%
==========================================
Files 113 113
Lines 18664 18668 +4
==========================================
+ Hits 4009 4013 +4
Misses 14349 14349
Partials 306 306 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ciaranRoche, marcolan018 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@marcolan018: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
OCM-6883 | fix: rosa describe admin can list the admin with custom name
https://issues.redhat.com/browse/OCM-6883
Signed-off-by: marcolan018 [email protected]
In this PR,
rosa describe admin
will list out all users incluster-admins
group.For the commands
rosa create admin
androsa delete admin
, they continue to only handle thecluster-admin
user incluster-admins
group. Update help messages for those commands to make this more clear