Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM-6858 | Add validator for node drain grace period in interactive mode #1866

Merged

Conversation

philipwu08
Copy link
Contributor

Add validator to check the value of the node drain grace period in interactive mode.

@openshift-ci openshift-ci bot requested review from hunterkepley and oriAdler March 20, 2024 21:53
@philipwu08 philipwu08 force-pushed the node-drain-validator branch 2 times, most recently from 9735552 to 837c600 Compare March 20, 2024 23:23
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 90.32258% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 21.33%. Comparing base (709d754) to head (76e5f4a).
Report is 4 commits behind head on master.

Files Patch % Lines
cmd/create/machinepool/nodepool.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1866      +/-   ##
==========================================
+ Coverage   21.11%   21.33%   +0.22%     
==========================================
  Files         104      113       +9     
  Lines       17693    19041    +1348     
==========================================
+ Hits         3736     4063     +327     
- Misses      13679    14666     +987     
- Partials      278      312      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pkg/helper/machinepools/helpers.go Outdated Show resolved Hide resolved
pkg/helper/machinepools/helpers.go Outdated Show resolved Hide resolved
pkg/helper/machinepools/helpers_test.go Outdated Show resolved Hide resolved
pkg/helper/machinepools/helpers.go Outdated Show resolved Hide resolved
pkg/helper/machinepools/helpers.go Outdated Show resolved Hide resolved
pkg/helper/machinepools/helpers.go Show resolved Hide resolved
pkg/helper/machinepools/helpers.go Outdated Show resolved Hide resolved
@philipwu08 philipwu08 force-pushed the node-drain-validator branch from 837c600 to 5885f57 Compare March 22, 2024 19:13
@philipwu08 philipwu08 force-pushed the node-drain-validator branch from 5885f57 to 76e5f4a Compare March 22, 2024 19:59
@philipwu08
Copy link
Contributor Author

Thanks @robpblake for the review. Updated MR based on comments. Thanks.

Copy link
Contributor

@robpblake robpblake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2024
Copy link
Contributor

openshift-ci bot commented Mar 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: philipwu08, robpblake

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2024
Copy link
Contributor

openshift-ci bot commented Mar 25, 2024

@philipwu08: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit fa73f1c into openshift:master Mar 25, 2024
9 checks passed
@philipwu08 philipwu08 deleted the node-drain-validator branch June 10, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants