-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCM-6858 | Add validator for node drain grace period in interactive mode #1866
OCM-6858 | Add validator for node drain grace period in interactive mode #1866
Conversation
9735552
to
837c600
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1866 +/- ##
==========================================
+ Coverage 21.11% 21.33% +0.22%
==========================================
Files 104 113 +9
Lines 17693 19041 +1348
==========================================
+ Hits 3736 4063 +327
- Misses 13679 14666 +987
- Partials 278 312 +34 ☔ View full report in Codecov by Sentry. |
837c600
to
5885f57
Compare
5885f57
to
76e5f4a
Compare
Thanks @robpblake for the review. Updated MR based on comments. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: philipwu08, robpblake The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@philipwu08: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Add validator to check the value of the node drain grace period in interactive mode.