OCM-5718 | feat: Display login error if --govcloud supplied with commercial region

[hunterkepley]

OCM-5718 describes a bug where if a user attempts to log in supplying all commercial values, except passing in --govcloud flag, ROSA will be in 'fedramp mode' and will attempt to run commands on the wrong API endpoint. This MR makes sure users are meaning to log into govcloud by requiring a govcloud region upon logging in.

All other logic is kept the same, so if you only supply a govcloud region, or an encrypted token, etc, you will still log into fedramp. But, the --govcloud flag bug is solved by requiring the region upon passing the flag. If you pass --govcloud without meaning to (I.E. not providing a govcloud region), you will face an error. Other safeguard in this case already exists, where you must pass in a fedramp token to log in to govcloud anyway.

[codecov]

Codecov Report

Attention: Patch coverage is 50.00000% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 21.04%. Comparing base (692773c) to head (3f38569).
Report is 2 commits behind head on master.

Files	Patch %	Lines
cmd/login/cmd.go	50.00%	8 Missing and 3 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1844      +/-   ##
==========================================
+ Coverage   20.91%   21.04%   +0.12%     
==========================================
  Files         103      104       +1     
  Lines       17351    17688     +337     
==========================================
+ Hits         3629     3722      +93     
- Misses      13447    13688     +241     
- Partials      275      278       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[davidleerh]

/lgtm

[davidleerh]

/lgtm

[den-rgb]

/lgtm

[robpblake]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidleerh, den-rgb, hunterkepley, robpblake

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [robpblake]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@hunterkepley: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.