-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCM-6527 | feat: add describe ingress command #1841
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1841 +/- ##
==========================================
+ Coverage 22.51% 22.93% +0.41%
==========================================
Files 131 134 +3
Lines 20840 20975 +135
==========================================
+ Hits 4692 4810 +118
- Misses 15797 15810 +13
- Partials 351 355 +4 ☔ View full report in Codecov by Sentry. |
1041130
to
4a9abda
Compare
/remove-approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of comments, maybe we can improve test coverage too, im not great at reading codecov but seems like it's around 40% covered
@gdbranco: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gdbranco, hunterkepley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
OCM-6527