Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM-6527 | feat: add describe ingress command #1841

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

gdbranco
Copy link
Contributor

@gdbranco gdbranco commented Mar 12, 2024

@openshift-ci openshift-ci bot requested review from oriAdler and pvasant March 12, 2024 20:44
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2024
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 76.62338% with 36 lines in your changes are missing coverage. Please review.

Project coverage is 22.93%. Comparing base (0c02dc0) to head (7fd6c58).

Files Patch % Lines
pkg/ocm/ingresses.go 0.00% 15 Missing ⚠️
pkg/ingress/ingress.go 88.15% 6 Missing and 3 partials ⚠️
cmd/edit/ingress/cmd.go 0.00% 7 Missing ⚠️
pkg/output/output.go 0.00% 3 Missing ⚠️
cmd/describe/ingress/cmd.go 94.44% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1841      +/-   ##
==========================================
+ Coverage   22.51%   22.93%   +0.41%     
==========================================
  Files         131      134       +3     
  Lines       20840    20975     +135     
==========================================
+ Hits         4692     4810     +118     
- Misses      15797    15810      +13     
- Partials      351      355       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cmd/describe/ingress/cmd.go Outdated Show resolved Hide resolved
cmd/describe/ingress/cmd.go Outdated Show resolved Hide resolved
cmd/describe/ingress/cmd.go Outdated Show resolved Hide resolved
cmd/describe/ingress/cmd.go Outdated Show resolved Hide resolved
@gdbranco gdbranco force-pushed the feat/ocm-6527 branch 3 times, most recently from 1041130 to 4a9abda Compare March 13, 2024 13:48
@robpblake
Copy link
Contributor

/remove-approve

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 15, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 15, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 31, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 22, 2024
Copy link
Contributor

@hunterkepley hunterkepley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments, maybe we can improve test coverage too, im not great at reading codecov but seems like it's around 40% covered

cmd/describe/ingress/cmd.go Outdated Show resolved Hide resolved
cmd/describe/ingress/cmd.go Show resolved Hide resolved
cmd/describe/ingress/cmd.go Outdated Show resolved Hide resolved
Copy link
Contributor

openshift-ci bot commented Apr 22, 2024

@gdbranco: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hunterkepley
Copy link
Contributor

/lgtm

@hunterkepley
Copy link
Contributor

/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2024
Copy link
Contributor

openshift-ci bot commented Apr 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gdbranco, hunterkepley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 93dbc3c into openshift:master Apr 22, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants