Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM-6119 | fix: block users from passing region flag when creating an oidc provider #1786

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

davidleerh
Copy link
Contributor

@davidleerh davidleerh commented Feb 15, 2024

image

Indicate to users that passing / using the region flag is not allowed when creating the OIDC provider.

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (master@eaa3fa5). Click here to learn what that means.
Report is 98 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1786   +/-   ##
=========================================
  Coverage          ?   20.02%           
=========================================
  Files             ?       90           
  Lines             ?    16006           
  Branches          ?        0           
=========================================
  Hits              ?     3206           
  Misses            ?    12559           
  Partials          ?      241           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@openshift-merge-robot openshift-merge-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 6, 2024
@davidleerh davidleerh requested a review from gdbranco March 6, 2024 21:18
Copy link
Contributor

openshift-ci bot commented Mar 6, 2024

@davidleerh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gdbranco
Copy link
Contributor

gdbranco commented Mar 7, 2024

/lgtm

@gdbranco
Copy link
Contributor

gdbranco commented Mar 7, 2024

/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 7, 2024
Copy link
Contributor

openshift-ci bot commented Mar 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidleerh, gdbranco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2024
Copy link
Contributor

openshift-ci bot commented Mar 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidleerh, gdbranco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 8632922 into openshift:master Mar 7, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants