OCM-8283 | fix: kubelet-config edit prompt no longer shows up when ku…

…belet-configs are not targeted
openshift · May 28, 2024 · 9d205a6 · 9d205a6
1 parent aeb442a
commit 9d205a6
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/cmd/edit/machinepool/nodepool.go b/cmd/edit/machinepool/nodepool.go
@@ -183,7 +183,7 @@ func editNodePool(cmd *cobra.Command, nodePoolID string,
 				inputKubeletConfig = nodePool.KubeletConfigs()
 			}
 
-			// Skip if no tuning configs are available
+			// Skip if no kubelet configs are available
 			if len(availableKubeletConfigs) > 0 {
 				inputKubeletConfig, err = interactive.GetMultipleOptions(interactive.Input{
 					Question: "Kubelet config",
@@ -206,6 +206,7 @@ func editNodePool(cmd *cobra.Command, nodePoolID string,
 			os.Exit(1)
 		}
 		npBuilder.KubeletConfigs(inputKubeletConfig...)
+		isKubeletConfigSet = true
 	}
 
 	if isNodeDrainGracePeriodSet || interactive.Enabled() {
@@ -241,7 +242,7 @@ func editNodePool(cmd *cobra.Command, nodePoolID string,
 		return fmt.Errorf("Failed to create machine pool for hosted cluster '%s': %v", clusterKey, err)
 	}
 
-	if !promptForNodePoolNodeRecreate(nodePool, update, PromptToAcceptNodePoolNodeRecreate, r) {
+	if isKubeletConfigSet && !promptForNodePoolNodeRecreate(nodePool, update, PromptToAcceptNodePoolNodeRecreate, r) {
 		return nil
 	}