Skip to content

Commit

Permalink
OCM-7792 | fix: unhide breakglass and externalauth
Browse files Browse the repository at this point in the history
Signed-off-by: Maggie Chen <[email protected]>
  • Loading branch information
chenz4027 committed Apr 30, 2024
1 parent b2ab832 commit 4df1a99
Show file tree
Hide file tree
Showing 8 changed files with 15 additions and 23 deletions.
5 changes: 2 additions & 3 deletions cmd/create/breakglasscredential/cmd.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,8 @@ func makeCmd() *cobra.Command {
Long: "Create a break glass credential for a hosted control plane cluster with external authentication enabled.",
Example: ` # Interactively create a break glass credential to a cluster named "mycluster"
rosa create break-glass-credential --cluster=mycluster --interactive`,
Run: run,
Hidden: true,
Args: cobra.NoArgs,
Run: run,
Args: cobra.NoArgs,
}
}

Expand Down
5 changes: 2 additions & 3 deletions cmd/create/externalauthprovider/cmd.go
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,8 @@ var Cmd = &cobra.Command{
Long: "Configure a cluster to use an external authentication provider instead of an internal oidc provider.",
Example: ` # Interactively create an external authentication provider to a cluster named "mycluster"
rosa create external-auth-provider --cluster=mycluster --interactive`,
Run: run,
Hidden: true,
Args: cobra.NoArgs,
Run: run,
Args: cobra.NoArgs,
}

func init() {
Expand Down
5 changes: 2 additions & 3 deletions cmd/describe/breakglasscredential/cmd.go
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,8 @@ var Cmd = &cobra.Command{
Long: "Show details of a break glass credential on a cluster.",
Example: ` # Show details of a break glass credential with ID "12345" on a cluster named "mycluster"
rosa describe break-glass-credential 12345 --cluster=mycluster `,
Run: run,
Hidden: true,
Args: cobra.MaximumNArgs(2),
Run: run,
Args: cobra.MaximumNArgs(2),
}

var args struct {
Expand Down
5 changes: 2 additions & 3 deletions cmd/describe/externalauthprovider/cmd.go
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,8 @@ var Cmd = &cobra.Command{
Long: "Show details of an external authentication provider on a cluster.",
Example: ` # Show details of an external authentication provider named "exauth" on a cluster named "mycluster"
rosa describe external-auth-provider exauth --cluster=mycluster `,
Run: run,
Hidden: true,
Args: cobra.MaximumNArgs(1),
Run: run,
Args: cobra.MaximumNArgs(1),
}

var args struct {
Expand Down
3 changes: 1 addition & 2 deletions cmd/dlt/externalauthprovider/cmd.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,7 @@ var Cmd = &cobra.Command{
Long: "Delete an external authentication provider from a cluster.",
Example: ` # Delete an external authentication provider named exauth-1
rosa delete external-auth-provider exauth-1 --cluster=mycluster`,
Run: run,
Hidden: true,
Run: run,
Args: func(_ *cobra.Command, argv []string) error {
if len(argv) != 1 {
return fmt.Errorf(
Expand Down
5 changes: 2 additions & 3 deletions cmd/list/breakglasscredential/cmd.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,8 @@ var Cmd = &cobra.Command{
Long: "List break glass credential for a cluster.",
Example: ` # List all break glass credentials for a cluster named 'mycluster'"
rosa list break-glass-credentials -c mycluster`,
Run: run,
Args: cobra.NoArgs,
Hidden: true,
Run: run,
Args: cobra.NoArgs,
}

func init() {
Expand Down
5 changes: 2 additions & 3 deletions cmd/list/externalauthprovider/cmd.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,8 @@ var Cmd = &cobra.Command{
Long: "List external authentication provider for a cluster.",
Example: ` # List all external authentication providers for a cluster named 'mycluster'"
rosa list external-auth-provider -c mycluster`,
Run: run,
Args: cobra.NoArgs,
Hidden: true,
Run: run,
Args: cobra.NoArgs,
}

func init() {
Expand Down
5 changes: 2 additions & 3 deletions cmd/revoke/breakglasscredential/cmd.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,8 @@ var Cmd = &cobra.Command{
Long: "Revoke all the break glass credentials from a cluster.",
Example: ` # Revoke all break glass credentials
rosa revoke break-glass-credentials --cluster=mycluster`,
Run: run,
Hidden: true,
Args: cobra.NoArgs,
Run: run,
Args: cobra.NoArgs,
}

func init() {
Expand Down

0 comments on commit 4df1a99

Please sign in to comment.